From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v2] mempool: remove a redundant word "for" in
	comment
Date: Mon, 28 Nov 2016 14:25:18 +0100
Message-ID: <20161128142518.6ed7b6e0@platinum>
References: <1480214627-27666-1-git-send-email-wei.zhao1@intel.com>
 <20161128094212.135ce16c@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Wei Zhao <wei.zhao1@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f182.google.com (mail-wj0-f182.google.com
 [209.85.210.182]) by dpdk.org (Postfix) with ESMTP id 25370201
 for <dev@dpdk.org>; Mon, 28 Nov 2016 14:25:21 +0100 (CET)
Received: by mail-wj0-f182.google.com with SMTP id qp4so115879637wjc.3
 for <dev@dpdk.org>; Mon, 28 Nov 2016 05:25:21 -0800 (PST)
In-Reply-To: <20161128094212.135ce16c@platinum>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Wei,

On Mon, 28 Nov 2016 09:42:12 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:
> Hi Wenzhuo,

First, sorry for the mistake in your name my previous mail.

Please find below some other comments about the patch (on the form).

> On Sun, 27 Nov 2016 10:43:47 +0800
> Wei Zhao <wei.zhao1@intel.com> wrote:
> 
> > From: zhao wei <wei.zhao1@intel.com>
> > 
> > There is a redundant repetition word "for" in commnet line of the

commnet -> comment

> > file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
> > The word "for"appear twice in line 359 and 360.One of them is

Missing space after '"for"' and after '360.'


> > redundant, so delete it.
> > 
> > Fixes: 449c49b93a6b (" mempool: support handler operations")

We should have an empty line after the 'Fixes:' tag. The
check-git-log.sh can help you to notice these errors.

Also, it is important that no spaces are added in the title of the
commit. You can get the exact line with:
  git log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' <commitid>

> > Signed-off-by: zhao wei <wei.zhao1@intel.com>

The name in your .gitconfig should be the same than in you mail:
Wei Zhao <wei.zhao1@intel.com>

> > Acked-by: John McNamara <john.mcnamara@intel.com>  
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 

Please, could you also check the same comments in the other patch?

Last thing: when doing another version of the patch, you should add a
changelog that describes what was modified. They take place after the 3
dashes.

Thank you for contributing.

Regards,
Olivier