From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 4/4] shell: fix echo -e bashisms, simplify code
Date: Mon, 28 Nov 2016 16:05:10 +0100 [thread overview]
Message-ID: <20161128150510.GC4935@rei.lan> (raw)
In-Reply-To: <20161125210125.7299-4-petr.vorel@gmail.com>
Hi!
> --- a/testcases/kernel/fs/acl/tacl_xattr.sh
> +++ b/testcases/kernel/fs/acl/tacl_xattr.sh
> @@ -85,7 +85,7 @@ if [ $? != 0 ]
> then
> echo ""
> echo "FAILED: [ losetup ] Must have loop device support by kernel"
> - echo -e "\t to execute this script"
> + printf "\t to execute this script\n"
I guess that it's a bit cleaner to use printf for the whole block just
to be consistent.
> diff --git a/tools/strace_test/slay b/tools/strace_test/slay
> index a68e8c9..7c0fe07 100755
> --- a/tools/strace_test/slay
> +++ b/tools/strace_test/slay
> @@ -119,7 +119,7 @@ do
> echo -e "\\n\\n\\nI'm kicking your butt.\\n\\n\\n" | write $1 2>/dev/null
^
Missed one?
> else
> echo "${ME}: Sending $SIGSHOW signal to $1's process(es)..."
> - echo -e "\\n\\n\\nYour current session has been terminated.\\n\\n\\n" | \
> + printf "\\n\\n\\nYour current session has been terminated.\\n\\n\\n\n" | \
> write $1 2>/dev/null
> fi
> if [ "$SIGNAL" = "-clean" ]
Apart from that the patchset is obviously correct.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-11-28 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 21:01 [LTP] [PATCH v2 1/4] shell: fix bashisms: s/&>/>$1 2>&1/ Petr Vorel
2016-11-25 21:01 ` [LTP] [PATCH v2 2/4] make-file.sh: simplify, fix bashism Petr Vorel
2016-11-25 21:01 ` [LTP] [PATCH v2 3/4] shell: fix bashism (( )) Petr Vorel
2016-11-25 21:01 ` [LTP] [PATCH v2 4/4] shell: fix echo -e bashisms, simplify code Petr Vorel
2016-11-28 15:05 ` Cyril Hrubis [this message]
2016-11-28 22:05 ` Petr Vorel
2016-11-26 8:09 ` [LTP] [PATCH v2 1/4] shell: fix bashisms: s/&>/>$1 2>&1/ Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128150510.GC4935@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.