From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBNbz-0001SL-E6 for qemu-devel@nongnu.org; Mon, 28 Nov 2016 10:12:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBNbv-0007fm-Hy for qemu-devel@nongnu.org; Mon, 28 Nov 2016 10:12:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57024) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cBNbv-0007fK-D6 for qemu-devel@nongnu.org; Mon, 28 Nov 2016 10:12:51 -0500 Date: Mon, 28 Nov 2016 15:12:46 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20161128151245.GB6896@work-vm> References: <20161128133201.16104-1-dgilbert@redhat.com> <53664d7f-9492-f8b0-2997-7514d9021e03@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53664d7f-9492-f8b0-2997-7514d9021e03@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] pcspk migration compatibility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, kraxel@redhat.com, quintela@redhat.com, amit.shah@redhat.com, pavel.dovgaluk@ispras.ru * Paolo Bonzini (pbonzini@redhat.com) wrote: > > > On 28/11/2016 14:31, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Hi, > > 39c88f56 added VMState for pcspk but turned it on for > > all machine types, this breaks backwards compatibility > > to older machine types. > > > > If this is too late for 2.8 then I suggest we take the 1st > > of these two patches, which just makes it a property to flip > > for those of us who need it. Adding the 2nd patch after 2.8 > > might cause problems for people using 2.8 with 2.7 machine > > type. > > > > Dave > > > > Dr. David Alan Gilbert (2): > > migration/pcspk: Add a property to state if pcspk is migrated > > migration/pcspk: Turn migration of pcspk off for 2.7 and older > > > > hw/audio/pcspk.c | 10 ++++++++++ > > include/hw/i386/pc.h | 5 +++++ > > 2 files changed, 15 insertions(+) > > > > Wow, I didn't know optional sections existed. We could have used it for > hw/char/parallel.c, but that was added only a couple months before > optional sections. I'd forgotten that they existed and was about to write them to solve this problem, and then found the code I apparently reviewed a year or so ago :-) > Queued for 2.8. Thanks. Dave > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK