From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH v2] ASoC: intel: Fix crash at suspend/resume without card registration
Date: Mon, 28 Nov 2016 21:30:34 +0530 [thread overview]
Message-ID: <20161128160034.GL6408@localhost> (raw)
In-Reply-To: <20161125155406.7617-1-tiwai@suse.de>
On Fri, Nov 25, 2016 at 04:54:06PM +0100, Takashi Iwai wrote:
> When ASoC Intel SST Medfield driver is probed but without codec / card
> assigned, it causes an Oops and freezes the kernel at suspend/resume,
>
> PM: Suspending system (freeze)
> Suspending console(s) (use no_console_suspend to debug)
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000018
> IP: [<ffffffffc09d9409>] sst_soc_prepare+0x19/0xa0 [snd_soc_sst_mfld_platform]
> Oops: 0000 [#1] PREEMPT SMP
> CPU: 0 PID: 1552 Comm: systemd-sleep Tainted: G W 4.9.0-rc6-1.g5f5c2ad-default #1
> Call Trace:
> [<ffffffffb45318f9>] dpm_prepare+0x209/0x460
> [<ffffffffb4531b61>] dpm_suspend_start+0x11/0x60
> [<ffffffffb40d3cc2>] suspend_devices_and_enter+0xb2/0x710
> [<ffffffffb40d462e>] pm_suspend+0x30e/0x390
> [<ffffffffb40d2eba>] state_store+0x8a/0x90
> [<ffffffffb43c670f>] kobj_attr_store+0xf/0x20
> [<ffffffffb42b0d97>] sysfs_kf_write+0x37/0x40
> [<ffffffffb42b02bc>] kernfs_fop_write+0x11c/0x1b0
> [<ffffffffb422be68>] __vfs_write+0x28/0x140
> [<ffffffffb43728a8>] ? apparmor_file_permission+0x18/0x20
> [<ffffffffb433b2ab>] ? security_file_permission+0x3b/0xc0
> [<ffffffffb422d095>] vfs_write+0xb5/0x1a0
> [<ffffffffb422e3d6>] SyS_write+0x46/0xa0
> [<ffffffffb4719fbb>] entry_SYSCALL_64_fastpath+0x1e/0xad
>
> Add proper NULL checks in the PM code of mdfld driver.
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
next prev parent reply other threads:[~2016-11-28 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 15:54 [PATCH v2] ASoC: intel: Fix crash at suspend/resume without card registration Takashi Iwai
2016-11-28 16:00 ` Vinod Koul [this message]
2016-11-30 18:07 ` Applied "ASoC: intel: Fix crash at suspend/resume without card registration" to the asoc tree Mark Brown
2016-11-30 18:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128160034.GL6408@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.