From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] scripts: fix checkpatch from standard input
Date: Mon, 28 Nov 2016 16:21:10 +0100 [thread overview]
Message-ID: <20161128162110.23127b42@platinum> (raw)
In-Reply-To: <1479768161-6123-1-git-send-email-thomas.monjalon@6wind.com>
On Mon, 21 Nov 2016 23:42:41 +0100, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> When checking a valid patch from standard input,
> the footer lines of the report are not filtered out.
>
> The function check is called outside of any loop,
> so the statement continue has no effect and the footer is printed.
>
> Fixes: 8005feef421d ("scripts: add standard input to checkpatch")
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
The 'continue' statement is not always without effect. On my machine
(but it looks it's not the same everywhere):
- with dash, the 'continue' acts like a return in that case
- with bash, it displays an error:
"continue: only meaningful in a `for', `while', or `until' loop"
- with bash --posix, the 'continue' is ignored...
In my case, checkpatches.sh was displaying "0/1 valid" although there
was no error. This patch solves the issue, thanks.
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2016-11-28 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 22:42 [PATCH] scripts: fix checkpatch from standard input Thomas Monjalon
2016-11-28 15:21 ` Olivier Matz [this message]
2016-11-30 14:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128162110.23127b42@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.