From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/atomic: Constify drm_atomic_crtc_needs_modeset()
Date: Mon, 28 Nov 2016 18:31:07 +0200 [thread overview]
Message-ID: <20161128163107.GI31595@intel.com> (raw)
In-Reply-To: <877f7skba1.fsf@intel.com>
On Thu, Nov 24, 2016 at 08:01:10PM +0200, Jani Nikula wrote:
> On Thu, 24 Nov 2016, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > drm_atomic_crtc_needs_modeset() doesn't change the passed in
> > crtc state, so pass it as const.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Pushed to drm-misc-next. Thanks for the review.
> > ---
> > include/drm/drm_atomic.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
> > index 5d5f85db43f0..d6d241f63b9f 100644
> > --- a/include/drm/drm_atomic.h
> > +++ b/include/drm/drm_atomic.h
> > @@ -418,7 +418,7 @@ int drm_atomic_debugfs_cleanup(struct drm_minor *minor);
> > * should clear mode_changed during its ->atomic_check.
> > */
> > static inline bool
> > -drm_atomic_crtc_needs_modeset(struct drm_crtc_state *state)
> > +drm_atomic_crtc_needs_modeset(const struct drm_crtc_state *state)
> > {
> > return state->mode_changed || state->active_changed ||
> > state->connectors_changed;
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-11-28 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 17:47 [PATCH] drm/atomic: Constify drm_atomic_crtc_needs_modeset() ville.syrjala
2016-11-24 18:01 ` Jani Nikula
2016-11-28 16:31 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128163107.GI31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.