From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] drm/virtio: fix framebuffer sparse warning Date: Mon, 28 Nov 2016 17:28:24 +0200 Message-ID: <20161128172814-mutt-send-email-mst@kernel.org> References: <1480320322-23362-1-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB6A46E3F3 for ; Mon, 28 Nov 2016 15:28:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1480320322-23362-1-git-send-email-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMjgsIDIwMTYgYXQgMDk6MDU6MjFBTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiB2aXJ0aW8gdXNlcyBub3JtYWwgcmFtIGFzIGJhY2tpbmcgc3RvcmFnZSBmb3IgdGhl IGZyYW1lYnVmZmVyLCBzbyB3ZQo+IHNob3VsZCBhc3NpZ24gdGhlIGFkZHJlc3MgdG8gbmV3IHNj cmVlbl9idWZmZXIgKGFkZGVkIGJ5IGNvbW1pdAo+IDE3YTdiMGI0ZDk3NDlmODBkMzY1ZDdiYWZm NWRlYzJmNTRiMGU5OTIpIGluc3RlYWQgb2Ygc2NyZWVuX2Jhc2UuCj4gCj4gUmVwb3J0ZWQtYnk6 IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogR2Vy ZCBIb2ZmbWFubiA8a3JheGVsQHJlZGhhdC5jb20+CgpBY2tlZC1ieTogTWljaGFlbCBTLiBUc2ly a2luIDxtc3RAcmVkaGF0LmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmly dGdwdV9mYi5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVs ZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1 X2ZiLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfZmIuYwo+IGluZGV4IDIyNDJh ODAuLmRjMjk3NmMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1 X2ZiLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfZmIuYwo+IEBAIC0z MzcsNyArMzM3LDcgQEAgc3RhdGljIGludCB2aXJ0aW9fZ3B1ZmJfY3JlYXRlKHN0cnVjdCBkcm1f ZmJfaGVscGVyICpoZWxwZXIsCj4gIAlpbmZvLT5mYm9wcyA9ICZ2aXJ0aW9fZ3B1ZmJfb3BzOwo+ ICAJaW5mby0+cGl4bWFwLmZsYWdzID0gRkJfUElYTUFQX1NZU1RFTTsKPiAgCj4gLQlpbmZvLT5z Y3JlZW5fYmFzZSA9IG9iai0+dm1hcDsKPiArCWluZm8tPnNjcmVlbl9idWZmZXIgPSBvYmotPnZt YXA7Cj4gIAlpbmZvLT5zY3JlZW5fc2l6ZSA9IG9iai0+Z2VtX2Jhc2Uuc2l6ZTsKPiAgCWRybV9m Yl9oZWxwZXJfZmlsbF9maXgoaW5mbywgZmItPnBpdGNoZXNbMF0sIGZiLT5kZXB0aCk7Cj4gIAlk cm1fZmJfaGVscGVyX2ZpbGxfdmFyKGluZm8sICZ2ZmJkZXYtPmhlbHBlciwKPiAtLSAKPiAxLjgu My4xCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933211AbcK1P2c (ORCPT ); Mon, 28 Nov 2016 10:28:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34316 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932718AbcK1P2Z (ORCPT ); Mon, 28 Nov 2016 10:28:25 -0500 Date: Mon, 28 Nov 2016 17:28:24 +0200 From: "Michael S. Tsirkin" To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, David Airlie , "open list:VIRTIO GPU DRIVER" , open list Subject: Re: [PATCH] drm/virtio: fix framebuffer sparse warning Message-ID: <20161128172814-mutt-send-email-mst@kernel.org> References: <1480320322-23362-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480320322-23362-1-git-send-email-kraxel@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 28 Nov 2016 15:28:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2016 at 09:05:21AM +0100, Gerd Hoffmann wrote: > virtio uses normal ram as backing storage for the framebuffer, so we > should assign the address to new screen_buffer (added by commit > 17a7b0b4d9749f80d365d7baff5dec2f54b0e992) instead of screen_base. > > Reported-by: Michael S. Tsirkin > Signed-off-by: Gerd Hoffmann Acked-by: Michael S. Tsirkin > --- > drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c > index 2242a80..dc2976c 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_fb.c > +++ b/drivers/gpu/drm/virtio/virtgpu_fb.c > @@ -337,7 +337,7 @@ static int virtio_gpufb_create(struct drm_fb_helper *helper, > info->fbops = &virtio_gpufb_ops; > info->pixmap.flags = FB_PIXMAP_SYSTEM; > > - info->screen_base = obj->vmap; > + info->screen_buffer = obj->vmap; > info->screen_size = obj->gem_base.size; > drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); > drm_fb_helper_fill_var(info, &vfbdev->helper, > -- > 1.8.3.1