From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/6] ntp: fix missing optional dependencies
Date: Mon, 28 Nov 2016 23:24:53 +0100 [thread overview]
Message-ID: <20161128232453.6f8d3f36@free-electrons.com> (raw)
In-Reply-To: <20161114132238.6569-5-jezz@sysmic.org>
Hello,
On Mon, 14 Nov 2016 14:22:36 +0100, J?r?me Pouiller wrote:
> ntpq and ntpdc may depends on libedit and libcap.
>
> $ arm-linux-readelf -d ./usr/bin/ntpdc | grep NEEDED
> 0x00000001 (NEEDED) Shared library: [libcap.so.2]
> 0x00000001 (NEEDED) Shared library: [libm.so.6]
> 0x00000001 (NEEDED) Shared library: [libedit.so.0]
> 0x00000001 (NEEDED) Shared library: [libncursesw.so.6]
> 0x00000001 (NEEDED) Shared library: [libssl.so.1.0.0]
> 0x00000001 (NEEDED) Shared library: [libcrypto.so.1.0.0]
> 0x00000001 (NEEDED) Shared library: [libpthread.so.0]
> 0x00000001 (NEEDED) Shared library: [libc.so.6]
>
> However, build order with these libraries is not defined.
>
> In order to keep things simple, we enforce build order even if ntpq/ntpdc are
> not selected.
>
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
I've applied your patch, after doing one small change, see below.
> +ifeq ($(BR2_PACKAGE_LIBEDIT),y)
> +NTP_CONF_OPTS += --with-lineeditlibs=edit
> +NTP_DEPENDENCIES += libedit
> +else
> +NTP_CONF_OPTS += --with-lineeditlibs=""
I've replaced this by --without-lineeditlibs, which has the same
effect but is more commonly used in Buildroot. I did check that with
the libedit package installed, but forcing --without-lineeditlibs
really causes ntp to ignore libedit, which proves that it does work.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-28 22:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 13:22 [Buildroot] [PATCH 0/6] Warn user on missing optional dependencies Jérôme Pouiller
2016-11-14 13:22 ` [Buildroot] [PATCH 1/6] check-shlibs-deps: new script to check shared library dependencies Jérôme Pouiller
2017-02-06 21:04 ` Samuel Martin
2017-02-10 17:22 ` Jérôme Pouiller
2017-02-09 22:21 ` Thomas Petazzoni
2016-11-14 13:22 ` [Buildroot] [PATCH 2/6] pkg-generic: add check_shlibs_deps hooks Jérôme Pouiller
2017-02-06 21:04 ` Samuel Martin
2016-11-14 13:22 ` [Buildroot] [PATCH 3/6] infra: fix 'packages-file-list.txt' with TLP Jérôme Pouiller
2017-02-09 22:24 ` Thomas Petazzoni
2017-02-10 17:40 ` Jérôme Pouiller
2017-04-01 14:43 ` Thomas Petazzoni
2016-11-14 13:22 ` [Buildroot] [PATCH 4/6] ntp: fix missing optional dependencies Jérôme Pouiller
2016-11-28 22:24 ` Thomas Petazzoni [this message]
2016-11-14 13:22 ` [Buildroot] [PATCH 5/6] xterm: depend on libXinerama if appropriate Jérôme Pouiller
2016-11-14 13:22 ` [Buildroot] [PATCH 6/6] xserver_xorg-server: fix dependency with dbus Jérôme Pouiller
2016-12-17 15:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128232453.6f8d3f36@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.