All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] tools/Makefile: suppress "which swig" error output
Date: Mon, 28 Nov 2016 20:03:55 -0500	[thread overview]
Message-ID: <20161129010355.GF2546@bill-the-cat> (raw)
In-Reply-To: <1479557099-15818-1-git-send-email-andre.przywara@arm.com>

On Sat, Nov 19, 2016 at 12:04:59PM +0000, Andre Przywara wrote:

> The Makefile in tools/ tries to find the "swig" utility by calling "which".
> If nothing is found in the path, some versions of which will print an error
> message:
> $ make clean
> which: no swig in (/usr/local/bin:/usr/bin:/bin)
> 
> This does not apply to all version of "which", though:
> $ echo $0
> bash
> $ type which
> which is aliased to `type -path'
> $ which foo				<== this version is OK
> $ /usr/bin/which foo			<== this one is chatty
> /usr/bin/which: no foo in (/usr/local/bin:/usr/bin:/bin)
> $ sh					<== make uses /bin/sh
> sh-4.3$ which foo			<== no alias here
> which: no foo in (/usr/local/bin:/usr/bin:/bin)
> 
> This error message is rather pointless in our case, since we just have
> this very check to care for this. So add stderr redirection to suppress
> the message.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161128/d9e50515/attachment.sig>

      parent reply	other threads:[~2016-11-29  1:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-19 12:04 [U-Boot] [PATCH] tools/Makefile: suppress "which swig" error output Andre Przywara
2016-11-19 23:56 ` Simon Glass
2016-11-29  1:03 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161129010355.GF2546@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.