From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBbNf-0006ye-5K for qemu-devel@nongnu.org; Tue, 29 Nov 2016 00:55:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBbNc-0007x5-3c for qemu-devel@nongnu.org; Tue, 29 Nov 2016 00:55:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52496) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cBbNb-0007vj-Ts for qemu-devel@nongnu.org; Tue, 29 Nov 2016 00:55:00 -0500 Date: Tue, 29 Nov 2016 11:24:53 +0530 From: Amit Shah Message-ID: <20161129055453.GA2264@amit-lp.rh> References: <20161128133201.16104-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161128133201.16104-1-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] pcspk migration compatibility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, kraxel@redhat.com, quintela@redhat.com, pavel.dovgaluk@ispras.ru On (Mon) 28 Nov 2016 [13:31:59], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > 39c88f56 added VMState for pcspk but turned it on for > all machine types, this breaks backwards compatibility > to older machine types. > > If this is too late for 2.8 then I suggest we take the 1st > of these two patches, which just makes it a property to flip > for those of us who need it. Adding the 2nd patch after 2.8 > might cause problems for people using 2.8 with 2.7 machine > type. Reviewed-by: Amit Shah We should take both for 2.8, thanks! Amit