From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36888)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1cBeHO-0001WK-1w
	for qemu-devel@nongnu.org; Tue, 29 Nov 2016 04:00:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1cBeHK-0002H0-3A
	for qemu-devel@nongnu.org; Tue, 29 Nov 2016 04:00:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:5969)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <rjones@redhat.com>) id 1cBeHJ-0002Go-N5
	for qemu-devel@nongnu.org; Tue, 29 Nov 2016 04:00:42 -0500
Date: Tue, 29 Nov 2016 09:00:38 +0000
From: "Richard W.M. Jones" <rjones@redhat.com>
Message-ID: <20161129090038.GR11243@redhat.com>
References: <583cde9c.3223ed0a.7f0c2.886e@mx.google.com>
	<20161129083943.GP11243@redhat.com>
	<CAKXe6S+PYmkNLmhSwhsve8EQ6zTCYF+snhaLgKcCKobtyv128A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKXe6S+PYmkNLmhSwhsve8EQ6zTCYF+snhaLgKcCKobtyv128A@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Qiang <liq3ea@gmail.com>
Cc: qemu-devel@nongnu.org, Li Qiang <liqiang6-s@360.cn>

On Tue, Nov 29, 2016 at 04:56:55PM +0800, Li Qiang wrote:
> Hi
> 
> 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones <rjones@redhat.com>:
> 
> > On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote:
> > > From: Li Qiang <liqiang6-s@360.cn>
> > >
> > > When the Intel 6300ESB watchdog is hot unplug. The timer allocated
> > > in realize isn't freed thus leaking memory leak. This patch avoid
> > > this through adding the exit function.
> >
> > I will just note that the real hardware is not hot-pluggable.  However
> > we don't need to stick to the real hardware capabilities, so that's OK.
> >
> >
> 
> If the hardware is not hot-pluggable, we can set dc->hotpluggable = false.

No no no!  The hardware hasn't been made for a decade or two,
we don't need to stick with what the real hardware did.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org