From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Foley <pefoley2@pefoley.com>,
LKML <linux-kernel@vger.kernel.org>,
wangnan0@huawei.com
Subject: Re: [PATCH v2] Fix objtool with clang
Date: Tue, 29 Nov 2016 10:58:41 +0100 [thread overview]
Message-ID: <20161129095841.GA31494@krava> (raw)
In-Reply-To: <20161129093224.GA30999@krava>
On Tue, Nov 29, 2016 at 10:32:24AM +0100, Jiri Olsa wrote:
> On Mon, Nov 28, 2016 at 05:40:46PM -0200, Arnaldo Carvalho de Melo wrote:
>
> SNIP
>
> > LD /tmp/build/perf/pmu-events/pmu-events-in.o
> > CC /tmp/build/perf/arch/x86/util/intel-bts.o
> > CC /tmp/build/perf/builtin-buildid-cache.o
> > CC /tmp/build/perf/builtin-list.o
> > LD /tmp/build/perf/arch/x86/util/libperf-in.o
> > MKDIR /tmp/build/perf/arch/x86/tests/
> > CC /tmp/build/perf/arch/x86/tests/regs_load.o
> > /tmp/build/perf/.plugin_jbd2.o.cmd:3: *** empty variable name. Stop.
> > Makefile:192: recipe for target '/tmp/build/perf/plugin_jbd2-in.o' failed
> > make[2]: *** [/tmp/build/perf/plugin_jbd2-in.o] Error 2
> > Makefile.perf:591: recipe for target '/tmp/build/perf/libtraceevent-dynamic-list' failed
> > make[1]: *** [/tmp/build/perf/libtraceevent-dynamic-list] Error 2
> > make[1]: *** Waiting for unfinished jobs....
>
> ok, reproduced..
>
> the commit changes the output of the depfile for some reason,
> and our fixdep does not handle it correctly and produce wrong
> cmd file that failed to parse.. checking for fix
>
> depfile changes ('+' is after the change):
>
> -plugin_jbd2.o: plugin_jbd2.c /usr/include/stdc-predef.h \
> +plugin_jbd2.o plugin_jbd2.o: plugin_jbd2.c /usr/include/stdc-predef.h \
>
> jirka
so Fedora 25 puts old target name in the generated dependencies
in case you split the -Wp options.. while Fedora 24 the old way
and both F24 and F25 shows me same gcc version 6.2.1
(note that just the first command output with 2 targets is wrong for us)
Fedora 25:
[root@intel-denlow-r-02 ~]# gcc -o ex.o -c -Wp,-MD,krava -Wp,-MT,krava -g ex.c
[root@intel-denlow-r-02 ~]# cat krava
ex.o krava: ex.c /usr/include/stdc-predef.h /usr/include/stdio.h \
/usr/include/features.h /usr/include/sys/cdefs.h \
/usr/include/bits/wordsize.h /usr/include/gnu/stubs.h \
/usr/include/gnu/stubs-64.h \
/usr/lib/gcc/x86_64-redhat-linux/6.2.1/include/stddef.h \
/usr/include/bits/types.h /usr/include/bits/typesizes.h \
/usr/include/libio.h /usr/include/_G_config.h /usr/include/wchar.h \
/usr/lib/gcc/x86_64-redhat-linux/6.2.1/include/stdarg.h \
/usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h
[root@intel-denlow-r-02 ~]# gcc -o ex.o -c -Wp,-MD,krava,-MT,krava -g ex.c
[root@intel-denlow-r-02 ~]# cat krava
krava: ex.c /usr/include/stdc-predef.h /usr/include/stdio.h \
/usr/include/features.h /usr/include/sys/cdefs.h \
/usr/include/bits/wordsize.h /usr/include/gnu/stubs.h \
/usr/include/gnu/stubs-64.h \
/usr/lib/gcc/x86_64-redhat-linux/6.2.1/include/stddef.h \
/usr/include/bits/types.h /usr/include/bits/typesizes.h \
/usr/include/libio.h /usr/include/_G_config.h /usr/include/wchar.h \
/usr/lib/gcc/x86_64-redhat-linux/6.2.1/include/stdarg.h \
/usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h
Fedora 24:
[jolsa@krava trash]$ gcc -o ex.o -c -Wp,-MD,krava -Wp,-MT,krava -g ex.c
[jolsa@krava trash]$ cat krava
krava: ex.c /usr/include/stdc-predef.h /usr/include/stdio.h \
/usr/include/features.h /usr/include/sys/cdefs.h \
/usr/include/bits/wordsize.h /usr/include/gnu/stubs.h \
/usr/include/gnu/stubs-64.h \
/usr/lib/gcc/x86_64-redhat-linux/6.2.1/include/stddef.h \
/usr/include/bits/types.h /usr/include/bits/typesizes.h \
/usr/include/libio.h /usr/include/_G_config.h /usr/include/wchar.h \
/usr/lib/gcc/x86_64-redhat-linux/6.2.1/include/stdarg.h \
/usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h
[jolsa@krava trash]$ gcc -o ex.o -c -Wp,-MD,krava-Wp,-MT,krava -g ex.c
[jolsa@krava trash]$ cat krava
krava: ex.c /usr/include/stdc-predef.h /usr/include/stdio.h \
/usr/include/features.h /usr/include/sys/cdefs.h \
/usr/include/bits/wordsize.h /usr/include/gnu/stubs.h \
/usr/include/gnu/stubs-64.h \
/usr/lib/gcc/x86_64-redhat-linux/6.2.1/include/stddef.h \
/usr/include/bits/types.h /usr/include/bits/typesizes.h \
/usr/include/libio.h /usr/include/_G_config.h /usr/include/wchar.h \
/usr/lib/gcc/x86_64-redhat-linux/6.2.1/include/stdarg.h \
/usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h
I'll make fixdep to deal with that and try to have someone from gcc to clarify on this
jirka
next prev parent reply other threads:[~2016-11-29 9:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-26 22:20 [PATCH] Fix objtool with clang Peter Foley
2016-11-27 16:14 ` Jiri Olsa
2016-11-28 2:43 ` [PATCH v2] " Peter Foley
2016-11-28 11:39 ` Jiri Olsa
2016-11-28 15:00 ` Arnaldo Carvalho de Melo
2016-11-28 15:25 ` Peter Foley
2016-11-28 16:58 ` Jiri Olsa
2016-11-28 19:40 ` Arnaldo Carvalho de Melo
2016-11-28 20:08 ` Jiri Olsa
2016-11-29 9:32 ` Jiri Olsa
2016-11-29 9:58 ` Jiri Olsa [this message]
2016-11-29 14:28 ` Jiri Olsa
2016-11-29 14:33 ` Arnaldo Carvalho de Melo
2016-11-29 14:39 ` Jiri Olsa
2016-11-29 14:49 ` Arnaldo Carvalho de Melo
2016-11-29 15:24 ` Jiri Olsa
2016-12-01 13:00 ` [PATCHv3] tools build: Make fixdep parsing wait for last target Jiri Olsa
2016-12-01 17:48 ` Peter Foley
2016-12-01 18:53 ` Arnaldo Carvalho de Melo
2016-12-02 8:49 ` Jiri Olsa
2016-12-02 9:15 ` Jiri Olsa
2016-12-02 15:10 ` Arnaldo Carvalho de Melo
2016-12-06 8:20 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-11-28 19:35 ` [PATCH v2] Fix objtool with clang Arnaldo Carvalho de Melo
2016-12-06 8:20 ` [tip:perf/core] tools build: Fix objtool build " tip-bot for Peter Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129095841.GA31494@krava \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pefoley2@pefoley.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.