From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:60564 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755009AbcK2MI5 (ORCPT ); Tue, 29 Nov 2016 07:08:57 -0500 Date: Tue, 29 Nov 2016 13:08:55 +0100 From: Christoph Hellwig To: Amir Goldstein Cc: Christoph Hellwig , "Darrick J. Wong" , Al Viro , Anna.Schumaker@netapp.com, linux-fsdevel Subject: Re: [PATCH] fs: try to clone files first in vfs_copy_file_range Message-ID: <20161129120855.GA17073@lst.de> References: <1480063201-17906-1-git-send-email-hch@lst.de> <1480063201-17906-2-git-send-email-hch@lst.de> <20161129085525.GA6024@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Nov 29, 2016 at 12:28:01PM +0200, Amir Goldstein wrote: > On Tue, Nov 29, 2016 at 10:55 AM, Christoph Hellwig wrote: > > [fullquote removed, please get your email etiquette right or I'll stop > > responding] > > > > Sorry. I though the practice was to keep original patch in tact for review. The practice is to quote what's relevant. You generally have a lot of leeway to decide how much exactly you think fits, but a fullquote only ever makes sense when forwarding the mail to someone not previously involved with the thread. > To be fair, Clone is a fast metadata operation on xfs/btrfs/ocfs2. > I don't think we can know for sure how a future file systems will choose to > implement clone, nor can we tell for sure how any version of remote Windows CIFS > server will implement it. If it's not a fast and atomic metadata operation it must not implement clone_file_range, but should implement copy_file_range instead.