From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Andy Lutomirski <luto@amacapital.net>,
Andy Lutomirski <luto@kernel.org>,
Chunming Zhou <David1.Zhou@amd.com>,
Peter Zijlstra <peterz@infradead.org>,
Petr Mladek <pmladek@suse.com>,
Roman Pen <roman.penyaev@profitbricks.com>,
Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/5] Revert "kthread: Pin the stack via try_get_task_stack()/put_task_stack() in to_live_kthread() function"
Date: Tue, 29 Nov 2016 18:51:00 +0100 [thread overview]
Message-ID: <20161129175100.GA5333@redhat.com> (raw)
In-Reply-To: <20161129175037.GA5319@redhat.com>
This reverts commit 23196f2e5f5d810578a772785807dcdc2b9fdce9.
After the previous change struct kthread can't go away, no need to pin
the stack.
TODO: kill to_live_kthread().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/kthread.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/kernel/kthread.c b/kernel/kthread.c
index 9d64b65..7891a94 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -88,7 +88,7 @@ void free_kthread_struct(struct task_struct *k)
static struct kthread *to_live_kthread(struct task_struct *k)
{
struct completion *vfork = ACCESS_ONCE(k->vfork_done);
- if (likely(vfork) && try_get_task_stack(k))
+ if (likely(vfork))
return __to_kthread(vfork);
return NULL;
}
@@ -473,10 +473,8 @@ void kthread_unpark(struct task_struct *k)
{
struct kthread *kthread = to_live_kthread(k);
- if (kthread) {
+ if (kthread)
__kthread_unpark(k, kthread);
- put_task_stack(k);
- }
}
EXPORT_SYMBOL_GPL(kthread_unpark);
@@ -505,7 +503,6 @@ int kthread_park(struct task_struct *k)
wait_for_completion(&kthread->parked);
}
}
- put_task_stack(k);
ret = 0;
}
return ret;
@@ -541,7 +538,6 @@ int kthread_stop(struct task_struct *k)
__kthread_unpark(k, kthread);
wake_up_process(k);
wait_for_completion(&kthread->exited);
- put_task_stack(k);
}
ret = k->exit_code;
put_task_struct(k);
--
2.5.0
next prev parent reply other threads:[~2016-11-29 17:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 17:50 [PATCH v2 0/5] kthread: make struct kthread kmalloc'ed Oleg Nesterov
2016-11-29 17:50 ` [PATCH v2 1/5] " Oleg Nesterov
2016-12-08 13:43 ` [tip:sched/core] kthread: Make " tip-bot for Oleg Nesterov
2016-11-29 17:51 ` Oleg Nesterov [this message]
2016-12-08 13:43 ` [tip:sched/core] Revert "kthread: Pin the stack via try_get_task_stack()/put_task_stack() in to_live_kthread() function" tip-bot for Oleg Nesterov
2016-11-29 17:51 ` [PATCH v2 3/5] kthread: don't use to_live_kthread() in kthread_stop() Oleg Nesterov
2016-12-08 13:44 ` [tip:sched/core] kthread: Don't " tip-bot for Oleg Nesterov
2016-11-29 17:51 ` [PATCH v2 4/5] kthread: don't use to_live_kthread() in kthread_park() and kthread_unpark() Oleg Nesterov
2016-12-08 13:44 ` [tip:sched/core] kthread: Don't use to_live_kthread() in kthread_[un]park() tip-bot for Oleg Nesterov
2016-11-29 17:51 ` [PATCH v2 5/5] kthread: don't abuse kthread_create_on_cpu() in __kthread_create_worker() Oleg Nesterov
2016-12-08 13:45 ` [tip:sched/core] kthread: Don't " tip-bot for Oleg Nesterov
2016-12-08 13:07 ` [PATCH v2 0/5] kthread: make struct kthread kmalloc'ed Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129175100.GA5333@redhat.com \
--to=oleg@redhat.com \
--cc=David1.Zhou@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=roman.penyaev@profitbricks.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.