From: Greg KH <gregkh@linuxfoundation.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] drivers/usb: use READ_ONCE instead of deprecated ACCESS_ONCE
Date: Tue, 29 Nov 2016 20:24:26 +0100 [thread overview]
Message-ID: <20161129192426.GC3155@kroah.com> (raw)
In-Reply-To: <1479585265-7906-1-git-send-email-dave@stgolabs.net>
On Sat, Nov 19, 2016 at 11:54:25AM -0800, Davidlohr Bueso wrote:
> With the new standardized functions, we can replace all ACCESS_ONCE()
> calls across relevant drivers/usb/.
>
> ACCESS_ONCE() does not work reliably on non-scalar types. For example
> gcc 4.6 and 4.7 might remove the volatile tag for such accesses during
> the SRA (scalar replacement of aggregates) step:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
>
> Update the new calls regardless of if it is a scalar type, this is
> cleaner than having three alternatives.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Again, fix your From: line please.
next prev parent reply other threads:[~2016-11-29 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 19:54 [PATCH] drivers/usb: use READ_ONCE instead of deprecated ACCESS_ONCE Davidlohr Bueso
2016-11-20 9:39 ` Greg KH
2016-11-20 12:11 ` Mark Rutland
2016-11-20 16:09 ` Davidlohr Bueso
2016-11-21 7:15 ` Greg KH
2016-11-29 19:24 ` Greg KH [this message]
2016-11-30 13:50 ` [PATCH v2] " Davidlohr Bueso
2016-11-30 14:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129192426.GC3155@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.