From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] debugfs: improve formatting of debugfs_real_fops() Date: Tue, 29 Nov 2016 21:27:57 +0100 Message-ID: <20161129202756.GA14599@kroah.com> References: <1478798629-22318-1-git-send-email-jakub.kicinski@netronome.com> <20161129195805.GA2180@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Nicolai Stange , Christian Lamparter To: Jakub Kicinski Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:38956 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752706AbcK2U1s (ORCPT ); Tue, 29 Nov 2016 15:27:48 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Nov 29, 2016 at 12:11:37PM -0800, Jakub Kicinski wrote: > On Tue, Nov 29, 2016 at 11:58 AM, Greg Kroah-Hartman > wrote: > > On Thu, Nov 10, 2016 at 05:23:49PM +0000, Jakub Kicinski wrote: > >> Type of debugfs_real_fops() is longer than parameters and > >> the name, so there is no way to break the declaration nicely. > >> We have to go over 80 characters. > >> > >> Signed-off-by: Jakub Kicinski > >> --- > >> include/linux/debugfs.h | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > > > > Doesn't apply to my tree, what did you make this against? > > net-next, sorry, it > > Fixes: 68f929ff2654 ("debugfs: constify argument to debugfs_real_fops()") > > I think that change still haven't propagated out of Dave's tree. Dave > didn't take my fix up patch, though, so my plan was to resend it to > you during the merge window? Would that make sense? Sure, that will work. thanks, greg k-h