From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Anatole Denis <anatole@rezel.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/3] tests: Add regression test for malformed sets
Date: Tue, 29 Nov 2016 22:02:23 +0100 [thread overview]
Message-ID: <20161129210223.GB19613@salvia> (raw)
In-Reply-To: <3808d7e70955006aa8bebaab262110fdec391314.1480350941.git.anatole@rezel.net>
On Mon, Nov 28, 2016 at 05:43:09PM +0100, Anatole Denis wrote:
> see: 5afa5a164ff1c066af1ec56d875b91562882bd50
> When a malformed set is added, it was added before erroring out, causing a
> segfault further down when used. This tests for this case, ensuring that
> nftables doesn't segfault but errors correctly
>
> Signed-off-by: Anatole Denis <anatole@rezel.net>
> ---
> This test is maybe not that useful, but I used it to test that I didn't
> reintroduce the bug. Maybe a different naming rule for regression tests could
> be used ?
Another test to increase coverage doesn't harm, so I'm applying this.
Thanks!
next prev parent reply other threads:[~2016-11-29 21:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 16:43 [PATCH nft 1/3] evaluate: Add set to cache only when well-formed Anatole Denis
2016-11-28 16:43 ` [PATCH nft 2/3] tests: Add regression test for malformed sets Anatole Denis
2016-11-29 21:02 ` Pablo Neira Ayuso [this message]
2016-11-28 16:43 ` [PATCH nft 3/3] Revert "evaluate: check for NULL datatype in rhs in lookup expr" Anatole Denis
2016-11-29 21:02 ` Pablo Neira Ayuso
2016-11-29 20:55 ` [PATCH nft 1/3] evaluate: Add set to cache only when well-formed Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129210223.GB19613@salvia \
--to=pablo@netfilter.org \
--cc=anatole@rezel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.