All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] extensions: libip6t_ah: Fix translation of plain '-m ah'
Date: Tue, 29 Nov 2016 23:00:50 +0100	[thread overview]
Message-ID: <20161129220050.GA29033@salvia> (raw)
In-Reply-To: <20161125163239.6448-1-phil@nwl.cc>

On Fri, Nov 25, 2016 at 05:32:39PM +0100, Phil Sutter wrote:
> This is actually a limitation of ip6tables:
> 
> | # ip6tables -A INPUT -p ah -j ACCEPT
> | Warning: never matched protocol: ah. use extension match instead.
> 
> The working alternative is like so:
> 
> | # ip6tables -A INPUT -m ah -j ACCEPT
> 
> But upon translating, this statement gets ignored:
> 
> | $ ip6tables-translate -A INPUT -m ah -j ACCEPT
> | nft add rule ip6 filter INPUT  counter accept
> 
> This patch (ab)uses the 'space' variable to check if a parameter to the
> 'ah' match was present and if not translates the match into an extension
> header check:
> 
> | $ ip6tables-translate -A INPUT -m ah -j ACCEPT
> | add rule ip6 filter INPUT meta l4proto ah counter accept

Applied, thanks Phil.

      reply	other threads:[~2016-11-29 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25 16:32 [PATCH] extensions: libip6t_ah: Fix translation of plain '-m ah' Phil Sutter
2016-11-29 22:00 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161129220050.GA29033@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.