All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] xtables-translate: Fix chain type when translating nat table
Date: Tue, 29 Nov 2016 23:01:43 +0100	[thread overview]
Message-ID: <20161129220143.GD29033@salvia> (raw)
In-Reply-To: <20161128121416.27659-1-phil@nwl.cc>

On Mon, Nov 28, 2016 at 01:14:16PM +0100, Phil Sutter wrote:
> This makes the type of translated chains in nat table to be of type
> 'nat' instead of 'filter' which is incorrect.
> 
> Verified like so:
> 
> | $ iptables-restore-translate -f /dev/stdin <<EOF
> | *nat
> | :POSTROUTING ACCEPT [0:0]
> | [0:0] -A POSTROUTING -j MASQUERADE
> | COMMIT
> | EOF
> | # Translated by ./install/sbin/iptables-restore-translate v1.6.0 on Mon Nov 28 12:11:30 2016
> | add table ip nat
> | add chain ip nat POSTROUTING { type nat hook postrouting priority 0; policy accept; }
> | add rule ip nat POSTROUTING counter masquerade
> 
> Ditto for ip6tables-restore-translate.

Also applied, thanks.

      reply	other threads:[~2016-11-29 22:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 12:14 [iptables PATCH] xtables-translate: Fix chain type when translating nat table Phil Sutter
2016-11-29 22:01 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161129220143.GD29033@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.