All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-ext4@vger.kernel.org, linux-mm@kvack.org,
	linux-nvdimm@lists.01.org, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 2/6] mm: Invalidate DAX radix tree entries only if appropriate
Date: Tue, 29 Nov 2016 15:17:57 -0700	[thread overview]
Message-ID: <20161129221757.GA16608@linux.intel.com> (raw)
In-Reply-To: <1479980796-26161-3-git-send-email-jack@suse.cz>

On Thu, Nov 24, 2016 at 10:46:32AM +0100, Jan Kara wrote:
> Currently invalidate_inode_pages2_range() and invalidate_mapping_pages()
> just delete all exceptional radix tree entries they find. For DAX this
> is not desirable as we track cache dirtiness in these entries and when
> they are evicted, we may not flush caches although it is necessary. This
> can for example manifest when we write to the same block both via mmap
> and via write(2) (to different offsets) and fsync(2) then does not
> properly flush CPU caches when modification via write(2) was the last
> one.
> 
> Create appropriate DAX functions to handle invalidation of DAX entries
> for invalidate_inode_pages2_range() and invalidate_mapping_pages() and
> wire them up into the corresponding mm functions.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>

For the DAX bits:
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-11-29 22:17 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24  9:46 [PATCH 0/6 v2] dax: Page invalidation fixes Jan Kara
2016-11-24  9:46 ` Jan Kara
2016-11-24  9:46 ` Jan Kara
2016-11-24  9:46 ` Jan Kara
2016-11-24  9:46 ` [PATCH 1/6] ext2: Return BH_New buffers for zeroed blocks Jan Kara
2016-11-24  9:46   ` Jan Kara
2016-11-24  9:46   ` Jan Kara
2016-11-29 17:48   ` Ross Zwisler
2016-11-29 17:48     ` Ross Zwisler
     [not found] ` <1479980796-26161-1-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-11-24  9:46   ` [PATCH 2/6] mm: Invalidate DAX radix tree entries only if appropriate Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-29 19:34     ` Johannes Weiner
2016-11-29 19:34       ` Johannes Weiner
     [not found]       ` <20161129193403.GA12396-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2016-11-30  8:08         ` Jan Kara
2016-11-30  8:08           ` Jan Kara
2016-11-30  8:08           ` Jan Kara
     [not found]           ` <20161130080841.GD16667-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-11-30 15:59             ` Johannes Weiner
2016-11-30 15:59               ` Johannes Weiner
2016-12-09 12:02           ` Jan Kara
2016-12-09 12:02             ` Jan Kara
2016-11-29 22:17     ` Ross Zwisler [this message]
2016-11-24  9:46   ` [PATCH 3/6] dax: Avoid page invalidation races and unnecessary radix tree traversals Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-24  9:46     ` Jan Kara
     [not found]     ` <1479980796-26161-4-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-11-29 22:31       ` Ross Zwisler
2016-11-29 22:31         ` Ross Zwisler
2016-11-29 22:31         ` Ross Zwisler
2016-11-30  8:23         ` Jan Kara
2016-11-30  8:23           ` Jan Kara
2016-11-24  9:46   ` [PATCH 4/6] dax: Finish fault completely when loading holes Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-24  9:46     ` Jan Kara
     [not found]     ` <1479980796-26161-5-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-12-01 22:13       ` Ross Zwisler
2016-12-01 22:13         ` Ross Zwisler
2016-11-24  9:46   ` [PATCH 6/6] ext4: Simplify DAX fault path Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-24  9:46     ` Jan Kara
2016-11-24  9:46 ` [PATCH 5/6] dax: Call ->iomap_begin without entry lock during dax fault Jan Kara
2016-11-24  9:46   ` Jan Kara
2016-11-24  9:46   ` Jan Kara
2016-11-24  9:46   ` Jan Kara
2016-12-01 22:24   ` Ross Zwisler
2016-12-01 22:24     ` Ross Zwisler
2016-12-01 23:27     ` Ross Zwisler
2016-12-01 23:27       ` Ross Zwisler
2016-12-02 10:12       ` Jan Kara
2016-12-02 10:08     ` Jan Kara
2016-12-02 10:08       ` Jan Kara
  -- strict thread matches above, loose matches on Subject: below --
2016-12-12 16:47 [PATCH 0/6 v3] dax: Page invalidation fixes Jan Kara
2016-12-12 16:47 ` [PATCH 2/6] mm: Invalidate DAX radix tree entries only if appropriate Jan Kara
2016-12-12 16:47   ` Jan Kara
2016-12-12 17:50   ` Johannes Weiner
2016-12-12 17:50     ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161129221757.GA16608@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.