From: Eduardo Valentin <edubezval@gmail.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Caesar Wang <wxt@rock-chips.com>,
rui.zhang@intel.com, heiko@sntech.de, smbarber@chromium.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error messages
Date: Tue, 29 Nov 2016 21:04:21 -0800 [thread overview]
Message-ID: <20161130050420.GB27079@localhost.localdomain> (raw)
In-Reply-To: <20161129054728.GA64845@google.com>
Hey,
On Mon, Nov 28, 2016 at 09:47:29PM -0800, Brian Norris wrote:
> Hi,
>
<cut>
> > > + __func__, table.mode);
> >
> > Given that we are improving messages, would it be more informative to
> > say that you have an invalid table mode?
>
> I considered the mode and ID listing to go hand in hand, so it was the
> whole table that is wrong. But it is just as well to say the "table
> mode" is wrong.
>
> Maybe even better: "%s: unknown table mode: %d\n".
>
Yup, that works for me, even better.
> And I guess same answer for patch 4, where you had the same question.
yes
>
> Brian
>
> > > + return -EINVAL;
next prev parent reply other threads:[~2016-11-30 5:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 11:11 [PATCH v3 0/5] thermal: fixes the rockchip thermal Caesar Wang
[not found] ` <1480331524-18741-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-11-28 11:12 ` [PATCH v3 1/5] thermal: rockchip: improve conversion error messages Caesar Wang
2016-11-28 11:12 ` Caesar Wang
2016-11-29 1:51 ` Eduardo Valentin
2016-11-29 5:47 ` Brian Norris
2016-11-30 5:04 ` Eduardo Valentin [this message]
2016-12-12 10:47 ` Caesar Wang
2016-11-28 11:12 ` [PATCH v3 2/5] thermal: rockchip: don't pass table structs by value Caesar Wang
2016-11-28 11:12 ` Caesar Wang
2016-11-28 11:12 ` [PATCH v3 4/5] thermal: rockchip: optimize the conversion table Caesar Wang
2016-11-28 11:12 ` Caesar Wang
2016-11-29 1:48 ` Eduardo Valentin
2016-11-30 6:29 ` Eduardo Valentin
2016-12-12 10:48 ` Caesar Wang
2016-11-28 11:12 ` [PATCH v3 5/5] thermal: rockchip: handle set_trips without the trip points Caesar Wang
2016-11-28 11:12 ` Caesar Wang
2016-11-28 11:12 ` [PATCH v3 3/5] thermal: rockchip: fixes invalid temperature case Caesar Wang
2016-11-28 18:47 ` Brian Norris
2016-11-29 1:45 ` Eduardo Valentin
[not found] ` <20161129014553.GA3097-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-11-29 21:57 ` Brian Norris
2016-11-29 21:57 ` Brian Norris
2016-11-30 5:02 ` Eduardo Valentin
2016-11-30 5:59 ` Brian Norris
2016-11-30 6:26 ` Eduardo Valentin
2016-12-12 10:46 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130050420.GB27079@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=briannorris@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rui.zhang@intel.com \
--cc=smbarber@chromium.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.