All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yan Laijun <yan.laijun@gmail.com>
Cc: devel@driverdev.osuosl.org, sergio.paracuellos@gmail.com,
	linux-kernel@vger.kernel.org, bhumirks@gmail.com
Subject: Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c  Fixed too long code line warnings.
Date: Wed, 30 Nov 2016 10:01:20 +0100	[thread overview]
Message-ID: <20161130090120.GB32672@kroah.com> (raw)
In-Reply-To: <20161130042913.GA28831@yanlaijun-OptiPlex-9020>

On Wed, Nov 30, 2016 at 12:29:13PM +0800, Yan Laijun wrote:
> Fixed checkpatch warning "line over 80 characters" in
> wlan-ng/hfa384x_usb.c file.
> 
> Signed-off-by: Yan Laijun <yan.laijun@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 5f11f6e..3447fc5 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
>  {
>  	struct wlandevice *wlandev = urb->context;
>  	struct hfa384x *hw;
> -	union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
> +	union hfa384x_usbin *usbin = NULL;

Why set this to NULL if you then assign it to something else a few lines
later?

thanks,

greg k-h

  reply	other threads:[~2016-11-30  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30  4:29 [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings Yan Laijun
2016-11-30  9:01 ` Greg KH [this message]
2016-12-02 10:08   ` Yan Laijun
2016-12-02 10:09     ` [PATCH v2] staging: wlan-ng: " Yan Laijun
2016-12-02 10:49       ` Markus Böhme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161130090120.GB32672@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhumirks@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=yan.laijun@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.