From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Peter Rosin <peda@axentia.se>, Phong Vo <pvo@apm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, Loc Ho <lho@apm.com>,
Thang Nguyen <tqnguyen@apm.com>, patches <patches@apm.com>,
Tin Huynh <tnhuynh@apm.com>
Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x
Date: Wed, 30 Nov 2016 12:01:45 +0200 [thread overview]
Message-ID: <20161130100145.GF1459@lahna.fi.intel.com> (raw)
In-Reply-To: <d1751969-3c8f-d4c0-8e99-74b9dd26bd98@samsung.com>
On Wed, Nov 30, 2016 at 10:58:33AM +0100, Jacek Anaszewski wrote:
> It certainly downgrades code readability, but in case there is
> similar surrounding code there are two options to keep the things
> consistent - either stick to the current style or change it.
> IMHO the latter would generate only unnecessary noise in this
> particular case.
Also that's the style we have been using when adding ACPI support to
drivers.
prev parent reply other threads:[~2016-11-30 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161130030845epcas5p2369d1c7cabb765ef0039b8e8d5aaa965@epcas5p2.samsung.com>
2016-11-30 3:08 ` [PATCH V3] leds: pca955x: Add ACPI support for pca955x Tin Huynh
2016-11-30 7:51 ` Jacek Anaszewski
2016-11-30 8:01 ` Jacek Anaszewski
2016-11-30 8:06 ` Tin Huynh
2016-11-30 8:17 ` Jacek Anaszewski
2016-11-30 8:23 ` Phong Vo
2016-11-30 9:00 ` Jacek Anaszewski
2016-11-30 9:10 ` Phong Vo
2016-11-30 9:27 ` Jacek Anaszewski
2016-11-30 9:36 ` Peter Rosin
2016-11-30 9:36 ` Peter Rosin
2016-11-30 9:58 ` Jacek Anaszewski
2016-11-30 10:01 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130100145.GF1459@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=j.anaszewski@samsung.com \
--cc=lho@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=patches@apm.com \
--cc=peda@axentia.se \
--cc=pvo@apm.com \
--cc=rjw@rjwysocki.net \
--cc=rpurdie@rpsys.net \
--cc=tnhuynh@apm.com \
--cc=tqnguyen@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.