From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC24W-00045K-5h for qemu-devel@nongnu.org; Wed, 30 Nov 2016 05:25:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC24S-0004mi-CL for qemu-devel@nongnu.org; Wed, 30 Nov 2016 05:25:04 -0500 Received: from mga01.intel.com ([192.55.52.88]:42108) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cC24S-0004lu-3p for qemu-devel@nongnu.org; Wed, 30 Nov 2016 05:25:00 -0500 Date: Wed, 30 Nov 2016 18:25:44 +0800 From: Yuanhan Liu Message-ID: <20161130102544.GS5048@yliu-dev.sh.intel.com> References: <20161130101017.13382-1-maxime.coquelin@redhat.com> <20161130101017.13382-2-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161130101017.13382-2-maxime.coquelin@redhat.com> Subject: Re: [Qemu-devel] [RFC v3 1/3] vhost-user: Add MTU protocol feature and op List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maxime Coquelin Cc: mst@redhat.com, aconole@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, fbl@redhat.com, berrange@redhat.com, mlureau@redhat.com, ktraynor@redhat.com, jasowang@redhat.com, "Harris, James R" On Wed, Nov 30, 2016 at 11:10:15AM +0100, Maxime Coquelin wrote: > +#define VHOST_USER_PROTOCOL_F_MTU 4 > > Message types > ------------- > @@ -470,6 +471,18 @@ Message types > The first 6 bytes of the payload contain the mac address of the guest to > allow the vhost user backend to construct and broadcast the fake RARP. > > + * VHOST_USER_SET_MTU One thing I have just thought of is that, though we currently have one vhost-user driver (net), SPDK here (James cc'ed) is proposing vhost-user for other devices, say SCSI. So maybe it's better to add some type prefix here, like VHOST_USER_NET_SET_MTU? --yliu