From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [RFC v3 00/10] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Date: Wed, 30 Nov 2016 10:37:14 +0000 Message-ID: <20161130103713.GB2724@arm.com> References: <1479215363-2898-1-git-send-email-eric.auger@redhat.com> <6c9012fd-070b-6218-48e7-69b37f2559dd@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <6c9012fd-070b-6218-48e7-69b37f2559dd-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Auger Eric Cc: drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, marc.zyngier-5wv7dgnIgG8@public.gmane.org, punit.agrawal-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Wed, Nov 30, 2016 at 10:49:33AM +0100, Auger Eric wrote: > On 15/11/2016 14:09, Eric Auger wrote: > > Following LPC discussions, we now report reserved regions through > > iommu-group sysfs reserved_regions attribute file. > > > > Reserved regions are populated through the IOMMU get_resv_region callback > > (former get_dm_regions), now implemented by amd-iommu, intel-iommu and > > arm-smmu. > > > > The intel-iommu reports the [FEE0_0000h - FEF0_000h] MSI window as an > > IOMMU_RESV_NOMAP reserved region. > > > > arm-smmu reports the MSI window (arbitrarily located at 0x8000000 and > > 1MB large) and the PCI host bridge windows. > > > > The series integrates a not officially posted patch from Robin: > > "iommu/dma: Allow MSI-only cookies". > > > > This series currently does not address IRQ safety assessment. > > I will respin this series taking into account Joerg's comment. Does > anyone have additional comments or want to put forward some conceptual > issues with the current direction and with this implementation? > > As for the IRQ safety assessment, in a first step I would propose to > remove the IOMMU_CAP_INTR_REMAP from arm-smmus and consider the > assignment as unsafe. Any objection? Well, yeah, because it's perfectly safe with GICv3. Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Wed, 30 Nov 2016 10:37:14 +0000 Subject: [RFC v3 00/10] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions In-Reply-To: <6c9012fd-070b-6218-48e7-69b37f2559dd@redhat.com> References: <1479215363-2898-1-git-send-email-eric.auger@redhat.com> <6c9012fd-070b-6218-48e7-69b37f2559dd@redhat.com> Message-ID: <20161130103713.GB2724@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 30, 2016 at 10:49:33AM +0100, Auger Eric wrote: > On 15/11/2016 14:09, Eric Auger wrote: > > Following LPC discussions, we now report reserved regions through > > iommu-group sysfs reserved_regions attribute file. > > > > Reserved regions are populated through the IOMMU get_resv_region callback > > (former get_dm_regions), now implemented by amd-iommu, intel-iommu and > > arm-smmu. > > > > The intel-iommu reports the [FEE0_0000h - FEF0_000h] MSI window as an > > IOMMU_RESV_NOMAP reserved region. > > > > arm-smmu reports the MSI window (arbitrarily located at 0x8000000 and > > 1MB large) and the PCI host bridge windows. > > > > The series integrates a not officially posted patch from Robin: > > "iommu/dma: Allow MSI-only cookies". > > > > This series currently does not address IRQ safety assessment. > > I will respin this series taking into account Joerg's comment. Does > anyone have additional comments or want to put forward some conceptual > issues with the current direction and with this implementation? > > As for the IRQ safety assessment, in a first step I would propose to > remove the IOMMU_CAP_INTR_REMAP from arm-smmus and consider the > assignment as unsafe. Any objection? Well, yeah, because it's perfectly safe with GICv3. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756880AbcK3Khf (ORCPT ); Wed, 30 Nov 2016 05:37:35 -0500 Received: from foss.arm.com ([217.140.101.70]:41708 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932969AbcK3KhP (ORCPT ); Wed, 30 Nov 2016 05:37:15 -0500 Date: Wed, 30 Nov 2016 10:37:14 +0000 From: Will Deacon To: Auger Eric Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, alex.williamson@redhat.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com Subject: Re: [RFC v3 00/10] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Message-ID: <20161130103713.GB2724@arm.com> References: <1479215363-2898-1-git-send-email-eric.auger@redhat.com> <6c9012fd-070b-6218-48e7-69b37f2559dd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c9012fd-070b-6218-48e7-69b37f2559dd@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2016 at 10:49:33AM +0100, Auger Eric wrote: > On 15/11/2016 14:09, Eric Auger wrote: > > Following LPC discussions, we now report reserved regions through > > iommu-group sysfs reserved_regions attribute file. > > > > Reserved regions are populated through the IOMMU get_resv_region callback > > (former get_dm_regions), now implemented by amd-iommu, intel-iommu and > > arm-smmu. > > > > The intel-iommu reports the [FEE0_0000h - FEF0_000h] MSI window as an > > IOMMU_RESV_NOMAP reserved region. > > > > arm-smmu reports the MSI window (arbitrarily located at 0x8000000 and > > 1MB large) and the PCI host bridge windows. > > > > The series integrates a not officially posted patch from Robin: > > "iommu/dma: Allow MSI-only cookies". > > > > This series currently does not address IRQ safety assessment. > > I will respin this series taking into account Joerg's comment. Does > anyone have additional comments or want to put forward some conceptual > issues with the current direction and with this implementation? > > As for the IRQ safety assessment, in a first step I would propose to > remove the IOMMU_CAP_INTR_REMAP from arm-smmus and consider the > assignment as unsafe. Any objection? Well, yeah, because it's perfectly safe with GICv3. Will