From mboxrd@z Thu Jan 1 00:00:00 1970 From: "gregkh@linuxfoundation.org" Subject: Re: [PATCH] usb:hub: readibility and consistency in coding style Date: Wed, 30 Nov 2016 13:02:32 +0100 Message-ID: <20161130120232.GA8761@kroah.com> References: <20161130063238epcms5p5b82d469df3d562bdfb1b6ca53ea1e226@epcms5p5> <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C15E6E2C2 for ; Wed, 30 Nov 2016 12:02:23 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Atul Raj Cc: "alcooperx@gmail.com" , "mathias.nyman@linux.intel.com" , Pankaj Singh , Viresh Kumar , "oneukum@suse.com" , "atulraj.nith@gmail.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "stern@rowland.harvard.edu" , "hansy@nvidia.com" , "baolu.lu@linux.intel.com" List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMzAsIDIwMTYgYXQgMTE6NTE6MzlBTSArMDAwMCwgQXR1bCBSYWogd3JvdGU6 Cj4gSXQgaXMgc3VnZ2VzdGVkIHRvIGtlZXAgYnJhY2VzIGlmIHRoZXJlIGlzIGEgY29tbWVudCBp biBpZiBjYXNlIGFzCj4gY29tbWVudCBhbHNvIHRha2VzIGEgbGluZS4KPiAtLS0KPiAgZHJpdmVy cy91c2IvY29yZS9odWIuYyB8IDQgKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKT2ssIHRoaXMgaXMgZ2V0dGluZyB0byBiZSBhIGpva2UuCgpU YWtlIGEgZmV3IGRheXMgb2ZmLCByZWxheCwgdGhlbiB0cnkgdG8gc2VuZCBhIHBhdGNoIHRoYXQg d29ya3MgdG8KeW91cnNlbGYgZmlyc3QsIGFuZCBydW4gaXQgdGhyb3VnaCBzY3JpcHRzL2NoZWNr cGF0Y2gucGwgdG8gdmVyaWZ5IHRoYXQKaXQgcmVhbGx5IGlzIGNvcnJlY3QuICBIaW50LCB0aGlz IG9uZSBpc24ndCBhdCBhbGwuCgpUaGVuLCBtYXliZSB5b3Ugc2hvdWxkIHN0YXJ0IGRvaW5nIHNv bWUgd29yayBvbiBkcml2ZXJzL3N0YWdpbmcvIGZpcnN0LAp3aGljaCBpcyB3aGVyZSBuZXcgZGV2 ZWxvcGVycyBzaG91bGQgc3RhcnQgb3V0IHRvIHdvcmsgb3V0IGFsbCBvZiB0aGVzZQppc3N1ZXMg c28geW91IGRvbid0IGJvdGhlciB0aGUgb3RoZXIgZGV2ZWxvcGVycyB3aG8gYXJlIHdvcmtpbmcg b24KYWRkaW5nIG5ldyBmZWF0dXJlcyBhbmQgZml4aW5nIGJ1Z3MuCgpBbHNvLCB3aHkgYXJlIHlv dSBpbmNsdWRpbmcgYSB0b24gb2YgcGVvcGxlIHdobyBoYXZlIG5vdGhpbmcgdG8gZG8gd2l0aAp1 c2IgcGF0Y2hlcyBvbiB0aGlzIG9uZT8KCmdvb2QgbHVjaywKCmdyZWcgay1oCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933233AbcK3MCb (ORCPT ); Wed, 30 Nov 2016 07:02:31 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45490 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933030AbcK3MCX (ORCPT ); Wed, 30 Nov 2016 07:02:23 -0500 Date: Wed, 30 Nov 2016 13:02:32 +0100 From: "gregkh@linuxfoundation.org" To: Atul Raj Cc: Viresh Kumar , "mathias.nyman@linux.intel.com" , "stern@rowland.harvard.edu" , "baolu.lu@linux.intel.com" , "oneukum@suse.com" , "hansy@nvidia.com" , "alcooperx@gmail.com" , "atulraj.nith@gmail.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Pankaj Singh Subject: Re: [PATCH] usb:hub: readibility and consistency in coding style Message-ID: <20161130120232.GA8761@kroah.com> References: <20161130063238epcms5p5b82d469df3d562bdfb1b6ca53ea1e226@epcms5p5> <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2016 at 11:51:39AM +0000, Atul Raj wrote: > It is suggested to keep braces if there is a comment in if case as > comment also takes a line. > --- > drivers/usb/core/hub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Ok, this is getting to be a joke. Take a few days off, relax, then try to send a patch that works to yourself first, and run it through scripts/checkpatch.pl to verify that it really is correct. Hint, this one isn't at all. Then, maybe you should start doing some work on drivers/staging/ first, which is where new developers should start out to work out all of these issues so you don't bother the other developers who are working on adding new features and fixing bugs. Also, why are you including a ton of people who have nothing to do with usb patches on this one? good luck, greg k-h