From mboxrd@z Thu Jan 1 00:00:00 1970 From: "gregkh@linuxfoundation.org" Subject: Re: Re: [PATCH] usb:hub: readibility and consistency in coding style Date: Wed, 30 Nov 2016 14:49:42 +0100 Message-ID: <20161130134942.GB937@kroah.com> References: <20161130063238epcms5p5b82d469df3d562bdfb1b6ca53ea1e226@epcms5p5> <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3> <20161130123521epcms5p3aa0bd43d60fa69c7c7fbc1bbe7fa0099@epcms5p3> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A3446E366 for ; Wed, 30 Nov 2016 13:49:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161130123521epcms5p3aa0bd43d60fa69c7c7fbc1bbe7fa0099@epcms5p3> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Atul Raj Cc: "alcooperx@gmail.com" , "mathias.nyman@linux.intel.com" , Pankaj Singh , Viresh Kumar , "oneukum@suse.com" , "atulraj.nith@gmail.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "stern@rowland.harvard.edu" , "hansy@nvidia.com" , "baolu.lu@linux.intel.com" List-Id: dri-devel@lists.freedesktop.org CkE6IGh0dHA6Ly9lbi53aWtpcGVkaWEub3JnL3dpa2kvVG9wX3Bvc3QKUTogV2VyZSBkbyBJIGZp bmQgaW5mbyBhYm91dCB0aGlzIHRoaW5nIGNhbGxlZCB0b3AtcG9zdGluZz8KQTogQmVjYXVzZSBp dCBtZXNzZXMgdXAgdGhlIG9yZGVyIGluIHdoaWNoIHBlb3BsZSBub3JtYWxseSByZWFkIHRleHQu ClE6IFdoeSBpcyB0b3AtcG9zdGluZyBzdWNoIGEgYmFkIHRoaW5nPwpBOiBUb3AtcG9zdGluZy4K UTogV2hhdCBpcyB0aGUgbW9zdCBhbm5veWluZyB0aGluZyBpbiBlLW1haWw/CgpBOiBOby4KUTog U2hvdWxkIEkgaW5jbHVkZSBxdW90YXRpb25zIGFmdGVyIG15IHJlcGx5PwoKaHR0cDovL2Rhcmlu Z2ZpcmViYWxsLm5ldC8yMDA3LzA3L29uX3RvcAoKT24gV2VkLCBOb3YgMzAsIDIwMTYgYXQgMTI6 MzU6MjFQTSArMDAwMCwgQXR1bCBSYWogd3JvdGU6Cj4gSGkgR3JlZywKPiAKPiBJIGFtIHNvIGhh cHB5IHRvIGdldCBhIG1haWwgZnJvbSB5b3UgYW5kIEkgYW0gcmVhbGx5IHNvcnJ5IEdyZWcgdGhh dCBJIGRpc2FwcG9pbnRlZCB5b3UuCj4gSSB3aWxsIHRha2UgdXRtb3N0IGNhcmUgaW4gZnV0dXJl Lgo+IEkgd2lsbCBzZW5kIHlvdSBjb3JyZWN0IHBhdGNoIGluIHNvbWV0aW1lLgo+IGZvciB5b3Vy IHF1ZXMKPiAiQWxzbywgd2h5IGFyZSB5b3UgaW5jbHVkaW5nIGEgdG9uIG9mIHBlb3BsZSB3aG8g aGF2ZSBub3RoaW5nIHRvIGRvIHdpdGgKPiB1c2IgcGF0Y2hlcyBvbiB0aGlzIG9uZT8iCj4gCj4g SSBnb3QgdGhlIG5hbWUgb2YgcGVvcGxlIGZyb20gZ2V0X21haW50YWluZXIucGwKCldoZW4gdXNp bmcgZ2V0X21haW50YWluZXIucGwgb24gdGhpcyBwYXRjaCBpdCBkb2VzIG5vdCBpbmNsdWRlIHRo ZQpkcmktZGV2ZWwgbGlzdCwgc28gSSBkb24ndCB0aGluayB5b3UgdXNlZCBpdCBjb3JyZWN0bHku Cgo+IGZyb20gbm93IEkgd2lsbCBpbmNsdWRlIG9ubHkgeW91Lgo+IGlzIGl0IG9rPz8KCk5vLCBk byBpdCBjb3JyZWN0bHkuCgo+IG9uZSBtb3JlIHRoaW5nIGluIGFub3RoZXIgbWFpbCB5b3UgcmVw bGllZCB0byBtZSBhcwo+IE9uIFdlZCwgTm92IDMwLCAyMDE2IGF0IDExOjQwOjI4QU0gKzAwMDAs IEF0dWwgUmFqIHdyb3RlOgo+ID4gIGNoYW5nZXMgaW4gdjIKPiA+ICAgICAgICAgLSBhZGRlZCBi cmFjZXMgYXMgc3VnZ2VzdGVkLgo+IAo+IFdoeSBpcyB0aGlzIGhlcmU/Cj4gCj4gPiAKPiA+ICBk cml2ZXJzL3VzYi9jb3JlL2h1Yi5jIHwgMyArKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZG8geW91IGRpc2FncmVlIHdpdGggdmlyZXNo IGNvbW1lbnQgb2YgYnJhY2VzPz8/CgpJIGRpc2FncmVlIHRoYXQgdGhpcyBpcyBhIHZhbGlkIGNo YW5nZWxvZyBjb21tZW50LCBwbGVhc2UgcmVhZApEb2N1bWVudGF0aW9uL1N1Ym1pdHRpbmdQYXRj aGVzIGZvciB0aGUgY29ycmVjdCB3YXkgdG8gZG8gdGhpcy4KCkFnYWluLCBpZiB5b3UgZG9uJ3Qg aGF2ZSBleHBlcmllbmNlIGRvaW5nIHRoaXMsIHBsZWFzZSB3b3JrIGluIHRoZQpkcml2ZXJzL3N0 YWdpbmcvIGRpcmVjdG9yeSBmaXJzdCwgbm90IGluIHRoZSAiY29yZSIga2VybmVsLgoKdGhhbmtz LAoKZ3JlZyBrLWgKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757320AbcK3Nts (ORCPT ); Wed, 30 Nov 2016 08:49:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:52480 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757200AbcK3Nte (ORCPT ); Wed, 30 Nov 2016 08:49:34 -0500 Date: Wed, 30 Nov 2016 14:49:42 +0100 From: "gregkh@linuxfoundation.org" To: Atul Raj Cc: Viresh Kumar , "mathias.nyman@linux.intel.com" , "stern@rowland.harvard.edu" , "baolu.lu@linux.intel.com" , "oneukum@suse.com" , "hansy@nvidia.com" , "alcooperx@gmail.com" , "atulraj.nith@gmail.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Pankaj Singh Subject: Re: Re: [PATCH] usb:hub: readibility and consistency in coding style Message-ID: <20161130134942.GB937@kroah.com> References: <20161130063238epcms5p5b82d469df3d562bdfb1b6ca53ea1e226@epcms5p5> <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3> <20161130123521epcms5p3aa0bd43d60fa69c7c7fbc1bbe7fa0099@epcms5p3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161130123521epcms5p3aa0bd43d60fa69c7c7fbc1bbe7fa0099@epcms5p3> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Nov 30, 2016 at 12:35:21PM +0000, Atul Raj wrote: > Hi Greg, > > I am so happy to get a mail from you and I am really sorry Greg that I disappointed you. > I will take utmost care in future. > I will send you correct patch in sometime. > for your ques > "Also, why are you including a ton of people who have nothing to do with > usb patches on this one?" > > I got the name of people from get_maintainer.pl When using get_maintainer.pl on this patch it does not include the dri-devel list, so I don't think you used it correctly. > from now I will include only you. > is it ok?? No, do it correctly. > one more thing in another mail you replied to me as > On Wed, Nov 30, 2016 at 11:40:28AM +0000, Atul Raj wrote: > > changes in v2 > > - added braces as suggested. > > Why is this here? > > > > > drivers/usb/core/hub.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > do you disagree with viresh comment of braces??? I disagree that this is a valid changelog comment, please read Documentation/SubmittingPatches for the correct way to do this. Again, if you don't have experience doing this, please work in the drivers/staging/ directory first, not in the "core" kernel. thanks, greg k-h