From: Jiri Benc <jbenc@redhat.com>
To: Jarno Rajahalme <jarno@ovn.org>
Cc: netdev@vger.kernel.org, pshelar@ovn.org, e@erig.me
Subject: Re: [PATCH v3 net-next 2/3] openvswitch: Use is_skb_forwardable() for length check.
Date: Wed, 30 Nov 2016 14:51:59 +0100 [thread overview]
Message-ID: <20161130145159.3cee7ba4@griffin> (raw)
In-Reply-To: <1480462253-114713-2-git-send-email-jarno@ovn.org>
On Tue, 29 Nov 2016 15:30:52 -0800, Jarno Rajahalme wrote:
> @@ -504,11 +485,20 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto)
> goto drop;
> }
>
> - if (unlikely(packet_length(skb, vport->dev) > mtu &&
> - !skb_is_gso(skb))) {
> - net_warn_ratelimited("%s: dropped over-mtu packet: %d > %d\n",
> - vport->dev->name,
> - packet_length(skb, vport->dev), mtu);
> + if (unlikely(!is_skb_forwardable(vport->dev, skb))) {
How does this work when the vlan tag is accelerated? Then we can be
over MTU, yet the check will pass.
Jiri
next prev parent reply other threads:[~2016-11-30 13:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 23:30 [PATCH v3 net-next 1/3] openvswitch: Add a missing break statement Jarno Rajahalme
2016-11-29 23:30 ` [PATCH v3 net-next 2/3] openvswitch: Use is_skb_forwardable() for length check Jarno Rajahalme
2016-11-30 7:23 ` Pravin Shelar
2016-11-30 13:51 ` Jiri Benc [this message]
2016-11-30 21:30 ` Jarno Rajahalme
2016-12-01 19:50 ` Pravin Shelar
2016-12-02 9:25 ` Jiri Benc
2016-12-05 0:22 ` Pravin Shelar
2016-12-08 20:50 ` Eric Garver
2016-12-09 8:49 ` Jiri Benc
2016-11-29 23:30 ` [PATCH v3 net-next 3/3] openvswitch: Fix skb->protocol for vlan frames Jarno Rajahalme
2016-11-30 7:34 ` Pravin Shelar
2016-11-30 14:30 ` Jiri Benc
2016-12-01 20:31 ` Pravin Shelar
2016-12-02 9:42 ` Jiri Benc
2016-12-02 9:49 ` Jiri Benc
2016-12-05 0:58 ` Pravin Shelar
2016-12-14 5:07 ` [PATCH v3 net-next 1/3] openvswitch: Add a missing break statement Pravin Shelar
2016-12-20 1:07 ` Jarno Rajahalme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130145159.3cee7ba4@griffin \
--to=jbenc@redhat.com \
--cc=e@erig.me \
--cc=jarno@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.