All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Oder Chiou <oder_chiou@realtek.com>,
	alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Bard Liao <bardliao@realtek.com>
Subject: Re: [PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040
Date: Wed, 30 Nov 2016 22:06:15 +0530	[thread overview]
Message-ID: <20161130163615.GG6408@localhost> (raw)
In-Reply-To: <20161130161920.10817-1-tiwai@suse.de>

On Wed, Nov 30, 2016 at 05:19:20PM +0100, Takashi Iwai wrote:
> Dell Wyse 3040 requires the platform workaround for enabling dmic and
> jack detection as defined for Braswell CRB.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> ---
> 
> I guess the platform data should be applied generically to all CHT
> machines instead of DMI matching?  DMI matching doesn't scale,
> obviously.

we ahve been doing this on other RT codecs like RT286/298 as well for combo
jack to work. Yeah a better solution would be welcomed :)

> 
>  sound/soc/codecs/rt5670.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
> index 98c7efbc6ee0..97bafac3bc15 100644
> --- a/sound/soc/codecs/rt5670.c
> +++ b/sound/soc/codecs/rt5670.c
> @@ -2827,6 +2827,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = {
>  			DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"),
>  		},
>  	},
> +	{
> +		.ident = "Dell Wyse 3040",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"),
> +		},
> +	},
>  	{}
>  };
>  
> -- 
> 2.10.2
> 

-- 
~Vinod

  reply	other threads:[~2016-11-30 16:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30 16:19 [PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040 Takashi Iwai
2016-11-30 16:36 ` Vinod Koul [this message]
2016-11-30 16:30   ` Takashi Iwai
2016-12-01  3:30     ` Vinod Koul
2016-12-01 10:50       ` Mark Brown
2016-11-30 17:16 ` Applied "ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161130163615.GG6408@localhost \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bardliao@realtek.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=oder_chiou@realtek.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.