From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: sparclinux@vger.kernel.org
Subject: Re: sunvnet: Question on tx control in original code
Date: Thu, 01 Dec 2016 02:41:47 +0000 [thread overview]
Message-ID: <20161201024147.GW24944@oracle.com> (raw)
In-Reply-To: <161e538d-f353-2075-280b-50767e6ec8d8@oracle.com>
On (11/30/16 17:25), Shannon Nelson wrote:
> I've recently been studying up on the sparc LDom environment and
> sunvnet, the virtual network device. In looking through the code I
> ran across an odd bit of tx control that I don't quite understand.
:
> In order to get into the if-block there needs to be a 0 or negative
> return from vnet_tx_dring_avail(), yet then we're checking it again,
> with no discernible delay, for a positive value. I don't see how we
> could get to the netif_tx_wake_queue() call - shouldn't there be
> some delay, or perhaps something that might bump the underlying
> channel before checking for more available space?
>
> Perhaps I've missed something?
And fwiw, Shannon asked me this question, and I too did not have the
history here. Perhaps DaveM remembers where this came from?
--Sowmini
next prev parent reply other threads:[~2016-12-01 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 1:25 sunvnet: Question on tx control in original code Shannon Nelson
2016-12-01 2:41 ` Sowmini Varadhan [this message]
2016-12-02 17:31 ` David Miller
2016-12-02 17:46 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201024147.GW24944@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.