From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v2 1/2] docs-rst: move the rules for svg and graphviz to Makefile.sphinx
Date: Thu, 1 Dec 2016 06:19:59 -0200 [thread overview]
Message-ID: <20161201061959.73940e52@vento.lan> (raw)
In-Reply-To: <20161130180338.4a303400@lwn.net>
Em Wed, 30 Nov 2016 18:03:38 -0700
Jonathan Corbet <corbet@lwn.net> escreveu:
> On Mon, 21 Nov 2016 17:27:03 -0200
> Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
>
> > Not only media documents may have images. So, move the
> > rules for building images from graphviz and from SVG to
> > the Documentation makefile.
>
> So I tried applying this one, but...
>
> > LaTeX Warning: File `{media/typical_media_device}.*' not found on input line 22
> > 4.
> >
> > ! Unable to load picture or PDF file 'media/typical_media_device.*'.
> > <to be read again>
> > }
> > l.224 ...egraphics{{media/typical_media_device}.*}
>
> ...so something's not quite right there still. Unapplied, for now.
>
> I'm thinking I'd like to button up docs-next for 4.10 pretty soon now;
> don't want end up with more patches than media, after all! :) So maybe
> this one can be fixed at leisure and go in for 4.11. I don't think we
> really need it urgently.
Weird, here it worked fine (I almost submitted it by mistake on
the patch series you merged yesterday). Maybe the DOTS or IMAGES
line may be missing some *.svg or *.dot file.
Yet, I agree that the best is not to merge it, specially since Markus
has already a RFC for a Sphinx extension that would avoid the need of
doing the conversion via Makefile. If it solves properly, we could merge
his patchset instead.
If something goes wrong with the extension, I'm keeping those two
patches, plus the one suggested by Daniel Vetter that uses find to
seek for the *.svg and *.dot file at the makefile on this branch:
https://git.linuxtv.org/mchehab/experimental.git/log/?h=svg-images-v2
Thanks,
Mauro
prev parent reply other threads:[~2016-12-01 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 19:27 [Ksummit-discuss] [PATCH v2 1/2] docs-rst: move the rules for svg and graphviz to Makefile.sphinx Mauro Carvalho Chehab
2016-11-21 19:27 ` Mauro Carvalho Chehab
2016-11-21 19:27 ` [Ksummit-discuss] [PATCH v2 2/2] docs-rst: add documentation about how to insert images Mauro Carvalho Chehab
2016-11-21 19:27 ` Mauro Carvalho Chehab
2016-12-01 1:03 ` [PATCH v2 1/2] docs-rst: move the rules for svg and graphviz to Makefile.sphinx Jonathan Corbet
2016-12-01 8:19 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201061959.73940e52@vento.lan \
--to=mchehab@s-opensource.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.