From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756603AbcLAHR6 (ORCPT ); Thu, 1 Dec 2016 02:17:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:52278 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbcLAHR4 (ORCPT ); Thu, 1 Dec 2016 02:17:56 -0500 Date: Thu, 1 Dec 2016 08:17:45 +0100 From: Greg Kroah-Hartman To: csmanjuvijay@gmail.com Cc: Alan Stern , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] USB: OHCI: ohci-pxa27x: remove useless functions Message-ID: <20161201071745.GE14521@kroah.com> References: <1480536139-3851-1-git-send-email-csmanjuvijay@gmail.com> <1480550389-9421-1-git-send-email-csmanjuvijay@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480550389-9421-1-git-send-email-csmanjuvijay@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2016 at 11:59:49PM +0000, csmanjuvijay@gmail.com wrote: > From: Manjunath Goudar > > The ohci_hcd_pxa27x_drv_probe function is not doing anything other > than calling usb_hcd_pxa27x_probe function so ohci_hcd_pxa27x_drv_probe > function is useless that is why removed ohci_hcd_pxa27x_drv_probe > function and renamed usb_hcd_pxa27x_probe function to > ohci_hcd_pxa27x_drv_probe for proper naming. > > The ohci_hcd_pxa27x_remove function is also not doing anything other than > calling usb_hcd_pxa27x_remove that is why removed ohci_hcd_pxa27x_remove > function and renamed usb_hcd_pxa27x_remove to ohci_hcd_pxa27x_remove for > proper naming. > > Signed-off-by: Manjunath Goudar > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Changelog v1 -> v2: > 1.Removed warnings and errors of checkpatch.pl script. > 2.Replaced unuseful with useless in patch commit message for proper meaning. > 3.Removed usb_disabled() from ohci_hcd_pxa27x_drv_probe function because it > is already existing in ohci_pxa27x_init function > --- > drivers/usb/host/ohci-pxa27x.c | 42 ++++++++++++++---------------------------- > 1 file changed, 14 insertions(+), 28 deletions(-) changelog should go below --- line. > > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c > index a667cf2..171f28f2 100644 > --- a/drivers/usb/host/ohci-pxa27x.c > +++ b/drivers/usb/host/ohci-pxa27x.c > @@ -157,9 +157,9 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) > uhcrhdb |= (0x7<<17); > break; > default: > - printk( KERN_ERR > + printk(KERN_ERR No, don't do checkpatch cleanups in portions of the code you are not actually changing for your "real" patch. That's a mess. You can send checkpatch patches as follow-on patches, but not with this one. thanks, greg k-h