From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Pan Bian <bianpan2016@163.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
<patches@opensource.wolfsonmicro.com>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error
Date: Thu, 1 Dec 2016 09:32:36 +0000 [thread overview]
Message-ID: <20161201093236.GJ1867@localhost.localdomain> (raw)
In-Reply-To: <1480573545-18588-1-git-send-email-bianpan2016@163.com>
On Thu, Dec 01, 2016 at 02:25:44PM +0800, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
> wm831x_clkout_is_prepared() returns "true" when it fails to read
> CLOCK_CONTROL_1. "true" means the device is already prepared. So
> return "true" on the read failure seems improper.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
Looks good to me:
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2016-12-01 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 6:25 [PATCH 1/1] clk: clk-wm831x: fix a logic error Pan Bian
2016-12-01 9:32 ` Charles Keepax [this message]
2016-12-08 0:23 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201093236.GJ1867@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=bianpan2016@163.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.