All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	sm8ax1@vfemail.net
Subject: Re: [Qemu-devel] GTK UI keycodes broken under Wayland
Date: Thu, 1 Dec 2016 09:35:00 +0000	[thread overview]
Message-ID: <20161201093500.GC9191@redhat.com> (raw)
In-Reply-To: <bb1916a1-ebc3-40a4-ff20-4e526086c9dc@redhat.com>

On Thu, Dec 01, 2016 at 09:32:34AM +0100, Thomas Huth wrote:
> On 01.12.2016 08:24, Stefan Hajnoczi wrote:
> > I recently upgraded to Fedora 25 which runs Wayland by default.
> > 
> > The GTK UI is now sending unknown keycodes to the guests.  Although
> > alphanumeric keys work, the cursor keys are broken.
> > 
> > There is X11-specific code for keycode mapping in ui/gtk.c.  Perhaps
> > something is needed to make that work under Wayland?
> 
> There is certainly something missing for Wayland. Somebody already
> reported this issue here and posted a "quick and dirty" patch:
> 
> https://bugs.launchpad.net/qemu/+bug/1578192

That patch doesn't seem to apply for me and does more than is
needed. I've just sent a simpler patch that ought to fix it,
though I've not personally tested it, so would appreciate
feedback from Stefan that his test VM keyboard works now.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

  reply	other threads:[~2016-12-01  9:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01  7:24 [Qemu-devel] GTK UI keycodes broken under Wayland Stefan Hajnoczi
2016-12-01  8:32 ` Thomas Huth
2016-12-01  9:35   ` Daniel P. Berrange [this message]
2016-12-01 10:55     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161201093500.GC9191@redhat.com \
    --to=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sm8ax1@vfemail.net \
    --cc=stefanha@gmail.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.