All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: richard@nod.at, marek.vasut@gmail.com,
	linux-mtd@lists.infradead.org, john@phrozen.org,
	cyrille.pitchen@atmel.com, computersforpeace@gmail.com,
	dwmw2@infradead.org
Subject: Re: [PATCH] mtd: nand: xway: fix build undefined MODULE_DEVICE_TABLE()
Date: Thu, 1 Dec 2016 13:36:27 +0100	[thread overview]
Message-ID: <20161201133627.38953fb0@bbrezillon> (raw)
In-Reply-To: <20161130225110.10759-1-hauke@hauke-m.de>

Hi Hauke,

On Wed, 30 Nov 2016 23:51:10 +0100
Hauke Mehrtens <hauke@hauke-m.de> wrote:

> The header file with the definition of MODULE_DEVICE_TABLE() was
> missing, add include for linux/module.h to fix the problem in 4.9.

I tried to enable this driver as a module, and the build failed because
of a missing symbol (see the following patch).
Now, if it's not supposed to be compiled as a module, then you should
modify the Kconfig accordingly.

Regards,

Boris

--->8---
diff --git a/arch/mips/lantiq/xway/sysctrl.c
b/arch/mips/lantiq/xway/sysctrl.c index 236193b5210b..29e753556597
100644 --- a/arch/mips/lantiq/xway/sysctrl.c
+++ b/arch/mips/lantiq/xway/sysctrl.c
@@ -156,6 +156,7 @@ static void __iomem *pmu_membase;
 static void __iomem *ltq_xbar_membase;
 void __iomem *ltq_cgu_membase;
 void __iomem *ltq_ebu_membase;
+EXPORT_SYMBOL(ltq_ebu_membase);
 
 static u32 ifccr = CGU_IFCCR;
 static u32 pcicr = CGU_PCICR;

  parent reply	other threads:[~2016-12-01 12:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30 22:51 [PATCH] mtd: nand: xway: fix build undefined MODULE_DEVICE_TABLE() Hauke Mehrtens
2016-12-01 10:35 ` Boris Brezillon
2016-12-01 12:36 ` Boris Brezillon [this message]
2016-12-01 13:02   ` John Crispin
2016-12-01 13:47     ` Boris Brezillon
2016-12-01 13:57       ` John Crispin
2016-12-04 19:15         ` Hauke Mehrtens
2016-12-04 19:19           ` John Crispin
2016-12-04 22:40   ` Hauke Mehrtens
2016-12-05 12:10     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161201133627.38953fb0@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@atmel.com \
    --cc=dwmw2@infradead.org \
    --cc=hauke@hauke-m.de \
    --cc=john@phrozen.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.