From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EB6A481F1A for ; Thu, 1 Dec 2016 07:39:41 -0800 (PST) Date: Thu, 1 Dec 2016 08:39:40 -0700 From: Ross Zwisler Subject: Re: [PATCH v2 3/6] dax: add tracepoint infrastructure, PMD tracing Message-ID: <20161201153940.GC5160@linux.intel.com> References: <1480549533-29038-1-git-send-email-ross.zwisler@linux.intel.com> <1480549533-29038-4-git-send-email-ross.zwisler@linux.intel.com> <20161201091628.7057580f@gandalf.local.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161201091628.7057580f@gandalf.local.home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Steven Rostedt Cc: Jan Kara , Andrew Morton , Matthew Wilcox , linux-nvdimm@lists.01.org, Dave Chinner , linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Ingo Molnar , Alexander Viro , linux-fsdevel@vger.kernel.org List-ID: On Thu, Dec 01, 2016 at 09:16:28AM -0500, Steven Rostedt wrote: > On Wed, 30 Nov 2016 16:45:30 -0700 > Ross Zwisler wrote: > > > > --- /dev/null > > +++ b/include/trace/events/fs_dax.h > > @@ -0,0 +1,68 @@ > > +#undef TRACE_SYSTEM > > +#define TRACE_SYSTEM fs_dax > > + > > +#if !defined(_TRACE_FS_DAX_H) || defined(TRACE_HEADER_MULTI_READ) > > +#define _TRACE_FS_DAX_H > > + > > +#include > > + > > +DECLARE_EVENT_CLASS(dax_pmd_fault_class, > > + TP_PROTO(struct inode *inode, struct vm_area_struct *vma, > > + unsigned long address, unsigned int flags, pgoff_t pgoff, > > + pgoff_t max_pgoff, int result), > > + TP_ARGS(inode, vma, address, flags, pgoff, max_pgoff, result), > > + TP_STRUCT__entry( > > + __field(dev_t, dev) > > + __field(unsigned long, ino) > > + __field(unsigned long, vm_start) > > + __field(unsigned long, vm_end) > > + __field(unsigned long, vm_flags) > > + __field(unsigned long, address) > > + __field(unsigned int, flags) > > + __field(pgoff_t, pgoff) > > + __field(pgoff_t, max_pgoff) > > + __field(int, result) > > For better compaction, I would put flags and result together, as they > are both ints. Otherwise, you'll probably have 4 empty bytes after > flags. Sure, will do for v3. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 1 Dec 2016 08:39:40 -0700 From: Ross Zwisler To: Steven Rostedt Cc: Ross Zwisler , linux-kernel@vger.kernel.org, Alexander Viro , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Ingo Molnar , Jan Kara , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org Subject: Re: [PATCH v2 3/6] dax: add tracepoint infrastructure, PMD tracing Message-ID: <20161201153940.GC5160@linux.intel.com> References: <1480549533-29038-1-git-send-email-ross.zwisler@linux.intel.com> <1480549533-29038-4-git-send-email-ross.zwisler@linux.intel.com> <20161201091628.7057580f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161201091628.7057580f@gandalf.local.home> Sender: owner-linux-mm@kvack.org List-ID: On Thu, Dec 01, 2016 at 09:16:28AM -0500, Steven Rostedt wrote: > On Wed, 30 Nov 2016 16:45:30 -0700 > Ross Zwisler wrote: > > > > --- /dev/null > > +++ b/include/trace/events/fs_dax.h > > @@ -0,0 +1,68 @@ > > +#undef TRACE_SYSTEM > > +#define TRACE_SYSTEM fs_dax > > + > > +#if !defined(_TRACE_FS_DAX_H) || defined(TRACE_HEADER_MULTI_READ) > > +#define _TRACE_FS_DAX_H > > + > > +#include > > + > > +DECLARE_EVENT_CLASS(dax_pmd_fault_class, > > + TP_PROTO(struct inode *inode, struct vm_area_struct *vma, > > + unsigned long address, unsigned int flags, pgoff_t pgoff, > > + pgoff_t max_pgoff, int result), > > + TP_ARGS(inode, vma, address, flags, pgoff, max_pgoff, result), > > + TP_STRUCT__entry( > > + __field(dev_t, dev) > > + __field(unsigned long, ino) > > + __field(unsigned long, vm_start) > > + __field(unsigned long, vm_end) > > + __field(unsigned long, vm_flags) > > + __field(unsigned long, address) > > + __field(unsigned int, flags) > > + __field(pgoff_t, pgoff) > > + __field(pgoff_t, max_pgoff) > > + __field(int, result) > > For better compaction, I would put flags and result together, as they > are both ints. Otherwise, you'll probably have 4 empty bytes after > flags. Sure, will do for v3. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932764AbcLAPjo (ORCPT ); Thu, 1 Dec 2016 10:39:44 -0500 Received: from mga04.intel.com ([192.55.52.120]:51879 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbcLAPjm (ORCPT ); Thu, 1 Dec 2016 10:39:42 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,282,1477983600"; d="scan'208";a="36222596" Date: Thu, 1 Dec 2016 08:39:40 -0700 From: Ross Zwisler To: Steven Rostedt Cc: Ross Zwisler , linux-kernel@vger.kernel.org, Alexander Viro , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Ingo Molnar , Jan Kara , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH v2 3/6] dax: add tracepoint infrastructure, PMD tracing Message-ID: <20161201153940.GC5160@linux.intel.com> Mail-Followup-To: Ross Zwisler , Steven Rostedt , linux-kernel@vger.kernel.org, Alexander Viro , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Ingo Molnar , Jan Kara , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org References: <1480549533-29038-1-git-send-email-ross.zwisler@linux.intel.com> <1480549533-29038-4-git-send-email-ross.zwisler@linux.intel.com> <20161201091628.7057580f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161201091628.7057580f@gandalf.local.home> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 01, 2016 at 09:16:28AM -0500, Steven Rostedt wrote: > On Wed, 30 Nov 2016 16:45:30 -0700 > Ross Zwisler wrote: > > > > --- /dev/null > > +++ b/include/trace/events/fs_dax.h > > @@ -0,0 +1,68 @@ > > +#undef TRACE_SYSTEM > > +#define TRACE_SYSTEM fs_dax > > + > > +#if !defined(_TRACE_FS_DAX_H) || defined(TRACE_HEADER_MULTI_READ) > > +#define _TRACE_FS_DAX_H > > + > > +#include > > + > > +DECLARE_EVENT_CLASS(dax_pmd_fault_class, > > + TP_PROTO(struct inode *inode, struct vm_area_struct *vma, > > + unsigned long address, unsigned int flags, pgoff_t pgoff, > > + pgoff_t max_pgoff, int result), > > + TP_ARGS(inode, vma, address, flags, pgoff, max_pgoff, result), > > + TP_STRUCT__entry( > > + __field(dev_t, dev) > > + __field(unsigned long, ino) > > + __field(unsigned long, vm_start) > > + __field(unsigned long, vm_end) > > + __field(unsigned long, vm_flags) > > + __field(unsigned long, address) > > + __field(unsigned int, flags) > > + __field(pgoff_t, pgoff) > > + __field(pgoff_t, max_pgoff) > > + __field(int, result) > > For better compaction, I would put flags and result together, as they > are both ints. Otherwise, you'll probably have 4 empty bytes after > flags. Sure, will do for v3.