From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/6] dax: Finish fault completely when loading holes
Date: Thu, 1 Dec 2016 15:13:11 -0700 [thread overview]
Message-ID: <20161201221311.GA13739@linux.intel.com> (raw)
In-Reply-To: <1479980796-26161-5-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
On Thu, Nov 24, 2016 at 10:46:34AM +0100, Jan Kara wrote:
> The only case when we do not finish the page fault completely is when we
> are loading hole pages into a radix tree. Avoid this special case and
> finish the fault in that case as well inside the DAX fault handler. It
> will allow us for easier iomap handling.
>
> Signed-off-by: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
This seems correct to me.
Reviewed-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
linux-nvdimm@lists.01.org, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 4/6] dax: Finish fault completely when loading holes
Date: Thu, 1 Dec 2016 15:13:11 -0700 [thread overview]
Message-ID: <20161201221311.GA13739@linux.intel.com> (raw)
In-Reply-To: <1479980796-26161-5-git-send-email-jack@suse.cz>
On Thu, Nov 24, 2016 at 10:46:34AM +0100, Jan Kara wrote:
> The only case when we do not finish the page fault completely is when we
> are loading hole pages into a radix tree. Avoid this special case and
> finish the fault in that case as well inside the DAX fault handler. It
> will allow us for easier iomap handling.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
This seems correct to me.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-01 22:13 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 9:46 [PATCH 0/6 v2] dax: Page invalidation fixes Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` [PATCH 1/6] ext2: Return BH_New buffers for zeroed blocks Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-29 17:48 ` Ross Zwisler
2016-11-29 17:48 ` Ross Zwisler
2016-11-24 9:46 ` [PATCH 5/6] dax: Call ->iomap_begin without entry lock during dax fault Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-12-01 22:24 ` Ross Zwisler
2016-12-01 22:24 ` Ross Zwisler
2016-12-01 23:27 ` Ross Zwisler
2016-12-01 23:27 ` Ross Zwisler
2016-12-02 10:12 ` Jan Kara
2016-12-02 10:08 ` Jan Kara
2016-12-02 10:08 ` Jan Kara
[not found] ` <1479980796-26161-1-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-11-24 9:46 ` [PATCH 2/6] mm: Invalidate DAX radix tree entries only if appropriate Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-29 19:34 ` Johannes Weiner
2016-11-29 19:34 ` Johannes Weiner
[not found] ` <20161129193403.GA12396-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2016-11-30 8:08 ` Jan Kara
2016-11-30 8:08 ` Jan Kara
2016-11-30 8:08 ` Jan Kara
[not found] ` <20161130080841.GD16667-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-11-30 15:59 ` Johannes Weiner
2016-11-30 15:59 ` Johannes Weiner
2016-12-09 12:02 ` Jan Kara
2016-12-09 12:02 ` Jan Kara
2016-11-29 22:17 ` Ross Zwisler
2016-11-24 9:46 ` [PATCH 3/6] dax: Avoid page invalidation races and unnecessary radix tree traversals Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
[not found] ` <1479980796-26161-4-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-11-29 22:31 ` Ross Zwisler
2016-11-29 22:31 ` Ross Zwisler
2016-11-29 22:31 ` Ross Zwisler
2016-11-30 8:23 ` Jan Kara
2016-11-30 8:23 ` Jan Kara
2016-11-24 9:46 ` [PATCH 4/6] dax: Finish fault completely when loading holes Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
[not found] ` <1479980796-26161-5-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-12-01 22:13 ` Ross Zwisler [this message]
2016-12-01 22:13 ` Ross Zwisler
2016-11-24 9:46 ` [PATCH 6/6] ext4: Simplify DAX fault path Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
2016-11-24 9:46 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2016-12-12 16:47 [PATCH 0/6 v3] dax: Page invalidation fixes Jan Kara
2016-12-12 16:47 ` [PATCH 4/6] dax: Finish fault completely when loading holes Jan Kara
2016-12-12 16:47 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201221311.GA13739@linux.intel.com \
--to=ross.zwisler-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.