From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cChnm-00012A-Dn for qemu-devel@nongnu.org; Fri, 02 Dec 2016 01:58:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cChnj-0005Uq-EO for qemu-devel@nongnu.org; Fri, 02 Dec 2016 01:58:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38198) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cChnj-0005U2-8K for qemu-devel@nongnu.org; Fri, 02 Dec 2016 01:58:31 -0500 Date: Fri, 2 Dec 2016 14:58:25 +0800 From: Peter Xu Message-ID: <20161202065825.GG21601@pxdev.xzpeter.org> References: <1480348315-13332-1-git-send-email-bd.aviv@gmail.com> <20161130092359.GC4731@pxdev.xzpeter.org> <20161202055925.GC21601@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Tian, Kevin" Cc: "Aviv B.D" , Jason Wang , Jan Kiszka , Alex Williamson , "qemu-devel@nongnu.org" , "Michael S. Tsirkin" , "Lan, Tianyu" On Fri, Dec 02, 2016 at 06:23:52AM +0000, Tian, Kevin wrote: [...] > > IIUC the vfio container is created in: > > > > vfio_realize > > vfio_get_group > > vfio_connect_container > > > > Along the way (for vfio_get_group()), we have: > > > > group = vfio_get_group(groupid, pci_device_iommu_address_space(pdev), errp); > > > > Here the address space is per device. If without vIOMMU, they will be > > pointed to the same system address space. However if with vIOMMU, > > that address space will be per-device, no? > > > > yes, I didn't note that fact. Tianyu also pointed it out in his reply. :-) Sorry I didn't see that just now. Thanks for the confirmation. :) Thanks, -- peterx