From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: make xfs btree stats less huge
Date: Fri, 2 Dec 2016 05:20:44 -0800 [thread overview]
Message-ID: <20161202132044.GC426@infradead.org> (raw)
In-Reply-To: <20161201103052.28453-2-david@fromorbit.com>
> --- a/fs/xfs/xfs_stats.h
> +++ b/fs/xfs/xfs_stats.h
> @@ -21,10 +21,30 @@
>
> #include <linux/percpu.h>
>
> +enum {
> + __XBTS_lookup = 0,
Add a comment on top of the enum to explain these are the
offsets into each btree type?
> +#define XFS_STATS_CALC_INDEX(member) \
> + (offsetof(struct __xfsstats, member) / (int)sizeof(__uint32_t))
what's that int cast for?
Except for these nitpicks this looks great:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-12-02 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 10:30 [PATCH 0/3] xfs: miscellaneous improvements for 4.10 Dave Chinner
2016-12-01 10:30 ` [PATCH 1/3] xfs: make xfs btree stats less huge Dave Chinner
2016-12-02 13:20 ` Christoph Hellwig [this message]
2016-12-05 1:14 ` Dave Chinner
2016-12-05 12:48 ` Christoph Hellwig
2016-12-01 10:30 ` [PATCH 2/3] xfs: use rhashtable to track buffer cache Dave Chinner
2016-12-05 17:04 ` Christoph Hellwig
2016-12-07 6:32 ` Dave Chinner
2016-12-01 10:30 ` [PATCH 3/3] xfs: optimise CRC updates Dave Chinner
2016-12-02 13:22 ` Christoph Hellwig
2016-12-04 22:12 ` Dave Chinner
2016-12-05 12:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202132044.GC426@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.