From: Eric Biggers <ebiggers@google.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: fix reading new encrypted symlinks on no-journal file systems
Date: Fri, 2 Dec 2016 10:05:31 -0800 [thread overview]
Message-ID: <20161202180531.GA3508@google.com> (raw)
In-Reply-To: <20161202171422.20724-1-tytso@mit.edu>
On Fri, Dec 02, 2016 at 12:14:22PM -0500, Theodore Ts'o wrote:
> On a filesystem with no journal, a symlink longer than about 32
> characters (exact length depending on padding for encryption) could not
> be followed or read immediately after being created in an encrypted
> directory. This happened because when the symlink data went through the
> delayed allocation path instead of the journaling path, the symlink was
> incorrectly detected as a "fast" symlink rather than a "slow" symlink
> until its data was written out.
>
> To fix this, disable delayed allocation for symlinks, since there is
> no benefit for delayed allocation anyway.
>
Looks good to me.
Eric
prev parent reply other threads:[~2016-12-02 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 17:50 [PATCH] ext4: fix reading new encrypted symlinks on no-journal filesystems Eric Biggers
2016-11-18 2:20 ` Andreas Dilger
2016-11-18 18:47 ` Eric Biggers
2016-11-18 21:52 ` Andreas Dilger
2016-11-21 23:19 ` Eric Biggers
2016-11-22 22:49 ` Andreas Dilger
2016-12-01 19:27 ` Theodore Ts'o
2016-12-01 19:57 ` Eric Biggers
2016-12-02 17:14 ` [PATCH] ext4: fix reading new encrypted symlinks on no-journal file systems Theodore Ts'o
2016-12-02 18:05 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202180531.GA3508@google.com \
--to=ebiggers@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.