From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756295AbcLBSWF (ORCPT ); Fri, 2 Dec 2016 13:22:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57194 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbcLBSWE (ORCPT ); Fri, 2 Dec 2016 13:22:04 -0500 Date: Fri, 2 Dec 2016 19:22:10 +0100 From: Greg KH To: Guenter Roeck Cc: Heikki Krogerus , Oliver Neukum , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCHv13 2/3] usb: USB Type-C connector class Message-ID: <20161202182210.GA18111@kroah.com> References: <20161124122144.26259-1-heikki.krogerus@linux.intel.com> <20161124122144.26259-3-heikki.krogerus@linux.intel.com> <20161129162744.GA2255@kroah.com> <20161130091910.GD32668@kuha.fi.intel.com> <20161202180439.GA25991@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161202180439.GA25991@roeck-us.net> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 02, 2016 at 10:04:39AM -0800, Guenter Roeck wrote: > The driver interface is not my area of expertise. As such, my testing > and understanding of that part was limited to "it appears to work, > it must be ok". I very much relied on you to get this part right. > > That makes me feel really bad. It isn't fun to have my "Reviewed-by" > on a patch that gets (and apparently deserves) a WTF from a senior > kernel maintainer. This hurts both your and my reputation, and obviously > will make me quite hesitant to add a "Reviewed-by:" to the next version > of the series. Hey, it doesn't bother me at all, I want and need your reviews of those portions that I don't know as well (i.e. the userspace api and functionality.) So don't take it personally, the driver model isn't that easy of a topic to mess with in places, loads of people get it wrong. > No more shortcuts, please. I totally agree :) Also, I want some Intel reviews on this, that should help make a lot of these types of issues go away... thanks, greg k-h