From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf-next] netfilter: nf_log: do not assume ethernet header in netdev family
Date: Sun, 4 Dec 2016 20:44:04 +0100 [thread overview]
Message-ID: <20161204194404.GA3516@salvia> (raw)
In-Reply-To: <1479134365-18623-1-git-send-email-zlpnobody@163.com>
On Mon, Nov 14, 2016 at 10:39:25PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> In netdev family, we will handle non ethernet packets, so using
> eth_hdr(skb)->h_proto is incorrect.
>
> Meanwhile, we can use socket(AF_PACKET...) to sending packets, so
> skb->protocol is not always set in bridge family.
>
> Add an extra parameter into nf_log_l2packet to solve this issue.
Applied, thanks Liping.
prev parent reply other threads:[~2016-12-04 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 14:39 [PATCH nf-next] netfilter: nf_log: do not assume ethernet header in netdev family Liping Zhang
2016-12-04 19:44 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161204194404.GA3516@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.