From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/aubio: disable unit tests with --notests
Date: Sun, 4 Dec 2016 22:02:40 +0100 [thread overview]
Message-ID: <20161204220240.408ea3ca@free-electrons.com> (raw)
In-Reply-To: <1480885126-517-3-git-send-email-romain.naour@gmail.com>
Hello,
On Sun, 4 Dec 2016 21:58:46 +0100, Romain Naour wrote:
> AUBIO_CONF_OPTS = \
> --disable-docs \
> - --disable-atlas
> + --disable-atlas \
> + --notests
> +
> +# Add --notests for each build step to avoid runing unit tests on the
> +# build machine.
> +AUBIO_MAKE_OPTS = --notests
> +AUBIO_INSTALL_STAGING_OPTS = --notests
> +AUBIO_INSTALL_TARGET_OPTS = --notests
The <pkg>_MAKE_OPTS, <pkg>_INSTALL_STAGING_OPTS and
<pkg>_INSTALL_TARGET_OPTS do not exist in the waf-package
infrastructure, so those lines are no-ops I believe. It seems like
passing --notests at configure time is sufficient.
Could you double check this?
(Other than that, great to see that there is no need for a patch!)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-12-04 21:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 20:58 [Buildroot] [PATCH 1/3] package/aubio: add upstream hash link Romain Naour
2016-12-04 20:58 ` [Buildroot] [PATCH 2/3] core: waf-package infra: add missing additional variables for each build step Romain Naour
2016-12-04 21:04 ` Thomas Petazzoni
2016-12-04 21:20 ` Romain Naour
2016-12-04 21:22 ` Thomas Petazzoni
2016-12-04 21:44 ` Romain Naour
2016-12-04 21:24 ` Yann E. MORIN
2016-12-04 21:35 ` Romain Naour
2016-12-04 21:41 ` Thomas Petazzoni
2016-12-04 23:32 ` Arnout Vandecappelle
2016-12-05 21:18 ` Romain Naour
2016-12-05 21:24 ` Thomas Petazzoni
2016-12-05 22:03 ` Arnout Vandecappelle
2016-12-04 20:58 ` [Buildroot] [PATCH 3/3] package/aubio: disable unit tests with --notests Romain Naour
2016-12-04 21:02 ` Thomas Petazzoni [this message]
2016-12-04 21:03 ` Thomas Petazzoni
2016-12-04 21:31 ` [Buildroot] [PATCH 1/3] package/aubio: add upstream hash link Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161204220240.408ea3ca@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.