All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] nginx-dav-ext: New package
Date: Sun, 4 Dec 2016 23:52:30 +0100	[thread overview]
Message-ID: <20161204235230.4be68e7c@free-electrons.com> (raw)
In-Reply-To: <1480438071-11906-1-git-send-email-johan.oudinet@gmail.com>

Hello,

I've applied to master, but after doing a number of changes. See below.

On Tue, 29 Nov 2016 17:47:51 +0100, Johan Oudinet wrote:

> diff --git a/package/nginx-dav-ext/nginx-dav-ext.mk b/package/nginx-dav-ext/nginx-dav-ext.mk
> new file mode 100644
> index 0000000..6c2b3a2
> --- /dev/null
> +++ b/package/nginx-dav-ext/nginx-dav-ext.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# nginx-dav-ext
> +#
> +################################################################################
> +
> +NGINX_DAV_EXT_VERSION = v0.0.3
> +NGINX_DAV_EXT_SITE = $(call github,arut,nginx-dav-ext-module,$(NGINX_DAV_EXT_VERSION))
> +

LICENSE and LICENSE_FILES were missing here, so I've added them.

> +NGINX_DAV_EXT_DEPENDENCIES = expat

> diff --git a/package/nginx/Config.in b/package/nginx/Config.in
> index e6f2d96..6f339c7 100644
> --- a/package/nginx/Config.in
> +++ b/package/nginx/Config.in
> @@ -85,6 +85,16 @@ config BR2_PACKAGE_NGINX_HTTP_DAV_MODULE
>  	help
>  	  Enable ngx_http_dav_module
>  
> +if BR2_PACKAGE_NGINX_HTTP_DAV_MODULE
> +
> +config BR2_PACKAGE_NGINX_HTTP_DAV_EXT_MODULE
> +	bool "ngx_http_dav_ext_module"
> +	select BR2_PACKAGE_NGINX_DAV_EXT
> +	help
> +	  Enable ngx_http_dav_ext_module
> +
> +endif # BR2_PACKAGE_NGINX_HTTP_DAV_MODULE

This was not really needed, and we don't do that for other external
nginx modules, so I've dropped this change. Enabling
BR2_PACKAGE_NGINX_DAV_EXT is enough to get this module enabled.

> +ifeq ($(BR2_PACKAGE_NGINX_HTTP_DAV_EXT_MODULE)$(BR2_PACKAGE_NGINX_DAV_EXT),yy)

So I've changed this to just:

ifeq ($(BR2_PACKAGE_NGINX_DAV_EXT),y)

> +NGINX_DEPENDENCIES += nginx-dav-ext
> +NGINX_CONF_OPTS += --add-module=$(NGINX_DAV_EXT_DIR)
> +endif

and moved the whole chunk next to the "upload" external module
handling, so that all external modules are handled in the same place in
nginx.mk.

I've also added a separate patch to add you in the DEVELOPERS file for
nginx-dav-ext (even though you will never receive a build failure about
it, since the build really takes place inside the nginx package).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2016-12-04 22:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 16:47 [Buildroot] [PATCH 1/1] nginx-dav-ext: New package Johan Oudinet
2016-12-01 10:34 ` Johan Oudinet
2016-12-04 22:52 ` Thomas Petazzoni [this message]
2016-12-05 10:58   ` Johan Oudinet
2016-12-05 11:14     ` Thomas Petazzoni
2016-12-05 13:20       ` Johan Oudinet
2016-12-05 13:33         ` Thomas Petazzoni
2016-12-05 13:41           ` Johan Oudinet
2016-12-05 13:53             ` Thomas Petazzoni
2016-12-05 14:31               ` Johan Oudinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161204235230.4be68e7c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.