From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDn1T-00053K-1d for qemu-devel@nongnu.org; Mon, 05 Dec 2016 01:45:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDn1O-0005SZ-5C for qemu-devel@nongnu.org; Mon, 05 Dec 2016 01:45:11 -0500 Received: from 001b2d01.pphosted.com ([148.163.156.1]:45979 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cDn1N-0005Rk-TT for qemu-devel@nongnu.org; Mon, 05 Dec 2016 01:45:06 -0500 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uB56ievE135589 for ; Mon, 5 Dec 2016 01:45:03 -0500 Received: from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208]) by mx0a-001b2d01.pphosted.com with ESMTP id 275352ga7c-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 05 Dec 2016 01:45:03 -0500 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 5 Dec 2016 01:45:02 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: References: <20161202181631.GH15373@work-vm> Date: Mon, 05 Dec 2016 00:44:53 -0600 Message-Id: <20161205064453.3996.48049@loki> Subject: Re: [Qemu-devel] Unable to add ram object with same ID after addition, migration and removal at the target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao , "Dr. David Alan Gilbert" Cc: "qemu-devel@nongnu.org" , Igor Mammedov , David Gibson Quoting Bharata B Rao (2016-12-04 21:51:32) > On Fri, Dec 2, 2016 at 11:46 PM, Dr. David Alan Gilbert > wrote: > = > * Bharata B Rao (bharata.rao@gmail.com) wrote: > > Hi, > > > > - Add ram object and dimm device at the source > > > > (qemu) object_add memory-backend-ram,id=3Dram0,size=3D128M > > (qemu) device_add pc-dimm,id=3Ddimm0,memdev=3Dram0 > > > > - Migrate the VM and remove the dimm device and ram object at the t= arget > > > > (qemu) device_del dimm0 > > (qemu) object_del ram0 > > > > - Adding the ram object with same id now at the target fails like t= his: > > > > (qemu) info memdev > > > > (qemu) object_add memory-backend-ram,id=3Dram0,size=3D128M > > Duplicate ID 'ram0' for object > > > > Same behaviour is seen on x86 and Power. The problem isn't seen if > > migration isn't involved (add, remove, add at the source itself). > = > Is this the same as the one Michael Roth posted a fix for a few days > back; 'monitor: fix object_del for command-line-created objects' > = > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg05479.html > = > = > Yes, this is same as above, I hadn't noticed Michael's fix. > = > Will be good to have this fix in 2.8. I considered shooting for 2.8, but since it's only triggerable with HMP (QMP doesn't use the QemuOpts-based parsing so it doesn't hit the duplicate ID error, so libvirt in turn would be uneffected), and doesn't seem to be a regression (AFAICT it's been an issue since object_del was introduced), I figured it could wait till 2.9/2.8.1. Definitely a pain for testing though... > = > Regards, > Bharata.