All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/3] nvme: Make controller state visible via sysfs
Date: Mon, 5 Dec 2016 16:37:31 +0100	[thread overview]
Message-ID: <20161205153731.GB6529@lst.de> (raw)
In-Reply-To: <1480936146-6406-4-git-send-email-sagi@grimberg.me>

> +	return sprintf(buf, "%s\n",
> +		       (unsigned)ctrl->state < ARRAY_SIZE(state_name) ?
> +		       state_name[ctrl->state] : "???");

I'd use an if here instead of the ? : and print unknown instead of the ???

Otherwise this looks fine to me:

Reviewed-by: Christoph Hellwig <hch at lst.de>

  parent reply	other threads:[~2016-12-05 15:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05 11:09 [PATCH 0/3] some useful fabrics patches Sagi Grimberg
2016-12-05 11:09 ` [PATCH 1/3] nvmet: delete controllers deletion upon subsystem release Sagi Grimberg
2016-12-05 11:39   ` Johannes Thumshirn
2016-12-05 14:08     ` Max Gurtovoy
2016-12-05 15:40   ` Christoph Hellwig
2016-12-05 17:08     ` Sagi Grimberg
2016-12-06  8:28       ` Christoph Hellwig
2016-12-05 11:09 ` [PATCH 2/3] nvmet: Make cntlid globally unique Sagi Grimberg
2016-12-05 11:38   ` Johannes Thumshirn
2016-12-05 14:08     ` Max Gurtovoy
2016-12-05 15:34   ` Christoph Hellwig
2016-12-05 17:06     ` Sagi Grimberg
2016-12-06  8:28       ` Christoph Hellwig
2016-12-06 23:23         ` J Freyensee
2016-12-05 11:09 ` [PATCH 3/3] nvme: Make controller state visible via sysfs Sagi Grimberg
2016-12-05 11:37   ` Johannes Thumshirn
2016-12-05 14:15   ` Max Gurtovoy
2016-12-05 17:05     ` Sagi Grimberg
2016-12-05 15:37   ` Christoph Hellwig [this message]
2016-12-05 17:06     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161205153731.GB6529@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.