From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbcLEQuQ (ORCPT ); Mon, 5 Dec 2016 11:50:16 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47924 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbcLEQuO (ORCPT ); Mon, 5 Dec 2016 11:50:14 -0500 Date: Mon, 5 Dec 2016 17:50:21 +0100 From: Greg KH To: Sergey Senozhatsky Cc: Andrew Morton , Minchan Kim , Steven Allen , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCHv3] zram: restrict add/remove attributes to root only Message-ID: <20161205165021.GA20595@kroah.com> References: <20161204124413.22595-1-sergey.senozhatsky@gmail.com> <20161205155845.20129-1-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161205155845.20129-1-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 06, 2016 at 12:58:45AM +0900, Sergey Senozhatsky wrote: > zram hot_add sysfs attribute is a very 'special' attribute - reading > from it creates a new uninitialized zram device. This file, by a mistake, > can be read by a 'normal' user at the moment, while only root must be > able to create a new zram device, therefore hot_add attribute must have > S_IRUSR mode, not S_IRUGO. > > Fixes: 6566d1a32bf72 ("zram: add dynamic device add/remove functionality") > Reported-by: Steven Allen > Cc: [4.2+] > Signed-off-by: Sergey Senozhatsky Acked-by: Greg Kroah-Hartman