From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] gstreamer1: fix compile for microblaze and xtensa architectures
Date: Mon, 5 Dec 2016 21:39:14 +0100 [thread overview]
Message-ID: <20161205213914.4e00e79e@gmx.net> (raw)
In-Reply-To: <20161205213031.7caf4172@free-electrons.com>
Hello Thomas,
On Mon, 5 Dec 2016 21:30:31 +0100, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 5 Dec 2016 21:27:15 +0100, Peter Seiderer wrote:
> > Fix unaligned access support detection introduced to gstreamer
> > by commit 'gstconfig.h: Detect unaligned access support at compile-time' ([1])
> > by assuming no unaligned support for unknown architectures.
> >
> > Fixes [2], [3]:
> >
> > ../gst/gstconfig.h:112:4: error: #error "Could not detect architecture; don't know whether it supports unaligned access! Please file a bug."
> > # error "Could not detect architecture; don't know whether it supports unaligned access! Please file a bug."
> >
> > [1] https://cgit.freedesktop.org/gstreamer/gstreamer/commit/?h=1.10&id=6ef601367e0f5adb7a8b02cec94dec04fccf701a
> > [2] http://autobuild.buildroot.net/results/c1cd60d3f44f2938e5f42453d034ea070898f837
> > [3] http://autobuild.buildroot.net/results/c3a6662f0acfda179a58cdad9165f36826229826
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> I've applied after fixing a minor typo (see below). Could you submit
> this patch upstream?
>
Done: https://bugzilla.gnome.org/show_bug.cgi?id=775661
> > +Better be save (assume no unaligned access) than sorry (bail out
>
> save -> safe
Ups, thanks for fixing...
Regards,
Peter
>
> > +with error message at compile time).
> > +
> > +Fixes compile for xtensa and microblaze architectures.
> > +
> > +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> Thanks a lot!
>
> Thomas
prev parent reply other threads:[~2016-12-05 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 20:27 [Buildroot] [PATCH v1] gstreamer1: fix compile for microblaze and xtensa architectures Peter Seiderer
2016-12-05 20:30 ` Thomas Petazzoni
2016-12-05 20:39 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205213914.4e00e79e@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.