All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Hesse <list@eworm.de>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Christian Hesse <mail@eworm.de>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH v2 1/1] add dkms configuration file dkms.conf
Date: Tue, 6 Dec 2016 10:35:51 +0100	[thread overview]
Message-ID: <20161206103551.038a3d3e@leda> (raw)
In-Reply-To: <CAHmME9pAz1e2keE0vH-cWORP7pRmhfoivFt0_=_4xEH9xUjLDA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

"Jason A. Donenfeld" <Jason@zx2c4.com> on Sat, 2016/12/03 23:21:
> I like the general idea here of including dkim in WireGuard now, 

'dkim' is mail security... We have dkms. ;)

> since
> basically all distros use it and ship the exact same logic. By putting
> it in WireGuard itself, I can provide maintenance over the
> interworkings, which will be helpful for downstream.
> 
> Another thing I can do is handle the installation myself. `make dkim`
> will then copy all the paths and create the dkim.conf file, etc. First
> question: is there a standard destination path to which files should
> be copied.

For Arch Linux we install dkms sources to /usr/src/$pkgname-$pkgver, so for
wireguard we have: /usr/src/wireguard-0.0.20161129/

So directory content looks something like this:

/usr/src/wireguard-0.0.20161129/
/usr/src/wireguard-0.0.20161129/Kbuild
/usr/src/wireguard-0.0.20161129/Kconfig
/usr/src/wireguard-0.0.20161129/Makefile
/usr/src/wireguard-0.0.20161129/dkms.conf
/usr/src/wireguard-0.0.20161129/*.c
/usr/src/wireguard-0.0.20161129/*.h
/usr/src/wireguard-0.0.20161129/crypto/
/usr/src/wireguard-0.0.20161129/crypto/*.S
/usr/src/wireguard-0.0.20161129/crypto/*.c
/usr/src/wireguard-0.0.20161129/crypto/*.h
/usr/src/wireguard-0.0.20161129/selftest/
/usr/src/wireguard-0.0.20161129/selftest/*.h

> Second question: what environment variable name do you
> think would be appropriate for representing the destination address
> (override)?

To have something like this would be great:

make DESTDIR="$pkgdir/" DKMSDIR="/usr/src/$pkgname-$pkgver" dkms
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2016-12-06  9:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-03 12:30 [PATCH 1/1] add dkms configuration file dkms.conf Christian Hesse
2016-12-03 12:42 ` [PATCH v2 " Christian Hesse
2016-12-03 22:21   ` Jason A. Donenfeld
2016-12-06  9:35     ` Christian Hesse [this message]
2016-12-06 18:14       ` Jason A. Donenfeld
2016-12-06 18:57         ` Jason A. Donenfeld
2016-12-06 20:15         ` Christian Hesse
2016-12-06 21:31           ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161206103551.038a3d3e@leda \
    --to=list@eworm.de \
    --cc=Jason@zx2c4.com \
    --cc=mail@eworm.de \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.