All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Wei Dai <wei.dai@intel.com>
Cc: david.marchand@6wind.com, dev@dpdk.org
Subject: Re: [PATCH v3] eal/linuxapp: fix return value check of mknod()
Date: Tue, 6 Dec 2016 11:44:59 +0100	[thread overview]
Message-ID: <20161206114459.0a05cbe0@platinum> (raw)
In-Reply-To: <1479365235-134903-1-git-send-email-wei.dai@intel.com>

Hi Wei,

On Thu, 17 Nov 2016 14:47:15 +0800, Wei Dai <wei.dai@intel.com> wrote:
> In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c,
> The return value of mknod() is ret, not f got by fopen().
> So the value of ret should be checked for mknod().
> 
> Fixes: f7f97c16048e ("pci: add option --create-uio-dev to run without
> hotplug")
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks

  reply	other threads:[~2016-12-06 10:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16  2:12 [PATCH] eal/linuxapp: fix return value check of mknod() Zhiyong Yang
2016-11-16  2:40 ` [PATCH v2] " Wei Dai
2016-11-16  3:28   ` Lu, Wenzhuo
2016-11-16 11:04     ` Ferruh Yigit
2016-11-16 15:17       ` Dai, Wei
2016-11-16 11:23   ` David Marchand
2016-11-16 15:18     ` Dai, Wei
2016-11-17  6:47   ` [PATCH v3] " Wei Dai
2016-12-06 10:44     ` Olivier Matz [this message]
2016-12-06 11:01       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161206114459.0a05cbe0@platinum \
    --to=olivier.matz@6wind.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=wei.dai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.